Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1296)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/ChromeTabbedActivity.java

Issue 2343023002: Switch WebVR to handle GvrApi management through VrShellDelegate (Closed)
Patch Set: Renamed onNativeLibraryReady to initializeNative Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/android/java/src/org/chromium/chrome/browser/vr_shell/VrShell.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/android/java/src/org/chromium/chrome/browser/ChromeTabbedActivity.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/ChromeTabbedActivity.java b/chrome/android/java/src/org/chromium/chrome/browser/ChromeTabbedActivity.java
index a0a63f5c752863501eb2cdb8dbf234156b2fcc2e..87d20a5b27f68a2617e9d840342648492bbd1648 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/ChromeTabbedActivity.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/ChromeTabbedActivity.java
@@ -241,6 +241,7 @@ public class ChromeTabbedActivity extends ChromeActivity implements OverviewMode
super.initializeCompositor();
mTabModelSelectorImpl.onNativeLibraryReady(getTabContentManager());
+ mVrShellDelegate.onNativeLibraryReady();
mTabModelObserver = new EmptyTabModelObserver() {
@Override
@@ -417,7 +418,7 @@ public class ChromeTabbedActivity extends ChromeActivity implements OverviewMode
handleDebugIntent(intent);
}
if (!mVrShellDelegate.isInVR() && mVrShellDelegate.isVrIntent(intent)) {
- mVrShellDelegate.enterVRIfNecessary();
+ mVrShellDelegate.enterVRIfNecessary(false);
}
} finally {
TraceEvent.end("ChromeTabbedActivity.onNewIntentWithNative");
@@ -606,7 +607,7 @@ public class ChromeTabbedActivity extends ChromeActivity implements OverviewMode
if (mVrShellDelegate.isVrIntent(intent)) {
// TODO(mthiesse): Improve startup when started from a VR intent. Right now
// we launch out of VR, partially load out of VR, then switch into VR.
- mVrShellDelegate.enterVRIfNecessary();
+ mVrShellDelegate.enterVRIfNecessary(false);
} else if (!mIntentHandler.shouldIgnoreIntent(ChromeTabbedActivity.this, intent)) {
mIntentWithEffect = mIntentHandler.onNewIntent(ChromeTabbedActivity.this,
intent);
@@ -1138,7 +1139,7 @@ public class ChromeTabbedActivity extends ChromeActivity implements OverviewMode
if (!currentModel.isIncognito()) currentModel.openMostRecentlyClosedTab();
RecordUserAction.record("MobileTabClosedUndoShortCut");
} else if (id == R.id.enter_vr_id) {
- mVrShellDelegate.enterVRIfNecessary();
+ mVrShellDelegate.enterVRIfNecessary(false);
} else {
return super.onMenuOrKeyboardAction(id, fromMenu);
}
« no previous file with comments | « no previous file | chrome/android/java/src/org/chromium/chrome/browser/vr_shell/VrShell.java » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698