device/vr/vr_service.mojom - Issue 2343023002: Switch WebVR to handle GvrApi management through VrShellDelegate

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: device/vr/vr_service.mojom

Issue 2343023002: Switch WebVR to handle GvrApi management through VrShellDelegate (Closed)

Patch Set: Addressed tedchoc@'s last feedback Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: device/vr/vr_service.mojom

diff --git a/device/vr/vr_service.mojom b/device/vr/vr_service.mojom

index 8f9331d41e5ca746d9e7e44c0c1dc5eade11ec8c..dd0d10713c25387ec7788b52045354244524972e 100644

--- a/device/vr/vr_service.mojom

+++ b/device/vr/vr_service.mojom

@@ -71,7 +71,7 @@ interface VRService {

RequestPresent(uint32 index) => (bool success);

ExitPresent(uint32 index);

- SubmitFrame(uint32 index, VRPose pose);

+ SubmitFrame(uint32 index, VRPose? pose);

UpdateLayerBounds(uint32 index, VRLayerBounds leftBounds, VRLayerBounds rightBounds);

};