Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1291)

Unified Diff: chrome/browser/android/vr_shell/vr_shell.h

Issue 2343023002: Switch WebVR to handle GvrApi management through VrShellDelegate (Closed)
Patch Set: Rebase Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/android/vr_shell/vr_shell.h
diff --git a/chrome/browser/android/vr_shell/vr_shell.h b/chrome/browser/android/vr_shell/vr_shell.h
index b415f2ab5a2692a16c498f296f27f4de6b037f72..96484f59040ca263441355165bc549f9880e501a 100644
--- a/chrome/browser/android/vr_shell/vr_shell.h
+++ b/chrome/browser/android/vr_shell/vr_shell.h
@@ -19,6 +19,7 @@
namespace vr_shell {
+class VrShellDelegate;
class VrShellRenderer;
@@ -27,6 +28,9 @@ class VrShell : public device::GvrDelegate {
VrShell(JNIEnv* env, jobject obj);
void Destroy(JNIEnv* env, const base::android::JavaParamRef<jobject>& obj);
+ void SetDelegate(JNIEnv* env,
+ const base::android::JavaParamRef<jobject>& obj,
+ jlong native_delegate);
void GvrInit(JNIEnv* env,
const base::android::JavaParamRef<jobject>& obj,
jlong native_gvr_api);
@@ -36,10 +40,11 @@ class VrShell : public device::GvrDelegate {
void DrawFrame(JNIEnv* env, const base::android::JavaParamRef<jobject>& obj);
void OnPause(JNIEnv* env, const base::android::JavaParamRef<jobject>& obj);
void OnResume(JNIEnv* env, const base::android::JavaParamRef<jobject>& obj);
+ void SetWebVrMode(JNIEnv* env,
+ const base::android::JavaParamRef<jobject>& obj,
+ bool enabled);
- // GvrDelegate
- void RequestWebVRPresent() override;
- void ExitWebVRPresent() override;
+ // device::GvrDelegate implementation
void SubmitWebVRFrame() override;
void UpdateWebVRTextureBounds(
int eye, float left, float top, float width, float height) override;
@@ -81,6 +86,7 @@ class VrShell : public device::GvrDelegate {
gvr::Sizei render_size_;
+ VrShellDelegate* delegate_;
std::unique_ptr<VrShellRenderer> vr_shell_renderer_;
base::android::ScopedJavaGlobalRef<jobject> j_vr_shell_;

Powered by Google App Engine
This is Rietveld 408576698