Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2241)

Unified Diff: chrome/browser/media/router/presentation_service_delegate_impl.h

Issue 2343013002: [Presentation API] (MR side) 1-UA: notify receiver page when receiver connection becomes available (Closed)
Patch Set: resolve code review comments from Derek Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/media/router/presentation_service_delegate_impl.h
diff --git a/chrome/browser/media/router/presentation_service_delegate_impl.h b/chrome/browser/media/router/presentation_service_delegate_impl.h
index fb63b45a55970065cfcd440df526c45e8c14bd96..fcbbeaf7c7c761672d5f5f9c3faf0583085e71af 100644
--- a/chrome/browser/media/router/presentation_service_delegate_impl.h
+++ b/chrome/browser/media/router/presentation_service_delegate_impl.h
@@ -35,6 +35,7 @@ namespace media_router {
class MediaRoute;
class MediaSinksObserver;
+class OffscreenPresentationManager;
class PresentationFrameManager;
class RouteRequestResult;
@@ -130,7 +131,6 @@ class PresentationServiceDelegateImpl
const content::PresentationSessionInfo& connection,
const content::PresentationConnectionStateChangedCallback&
state_changed_cb) override;
imcheng 2016/09/28 07:28:37 nit: add back the empty line to separate PSD imple
zhaobin 2016/09/29 17:20:44 Done.
-
// Callback invoked when a default PresentationRequest is started from a
// browser-initiated dialog.
void OnRouteResponse(const PresentationRequest& request,
@@ -164,6 +164,15 @@ class PresentationServiceDelegateImpl
int render_frame_id,
const MediaSource::Id& source_id) const;
+ void RegisterReceiverAvailableCallback(
imcheng 2016/09/28 07:28:37 Move these up to group them with the rest of PSD m
zhaobin 2016/09/29 17:20:44 Done.
+ const content::ReceiverConnectionAvailableCallback&
+ receiver_available_callback) override {}
imcheng 2016/09/28 07:28:37 Add a NOTREACHED() since we don't expect this to b
zhaobin 2016/09/29 17:20:44 Done.
+
+ void RegisterOffscreenPresentationClient(
+ int render_process_id,
+ int render_frame_id,
+ content::OffscreenPresentationClient*) override;
imcheng 2016/09/28 07:28:37 Please name the client parameter
zhaobin 2016/09/29 17:20:44 Done.
+
private:
friend class content::WebContentsUserData<PresentationServiceDelegateImpl>;
FRIEND_TEST_ALL_PREFIXES(PresentationServiceDelegateImplTest,

Powered by Google App Engine
This is Rietveld 408576698