[Presentation API] (MR side) 1-UA: notify receiver page when receiver connection becomes available

content/browser/presentation/presentation_service_impl.h

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CONTENT_BROWSER_PRESENTATION_PRESENTATION_SERVICE_IMPL_H_
 #define CONTENT_BROWSER_PRESENTATION_PRESENTATION_SERVICE_IMPL_H_
 
 #include <deque>
 #include <map>
 #include <memory>
+#include <set>
 #include <string>
 #include <vector>
 
 #include "base/callback.h"
 #include "base/compiler_specific.h"
 #include "base/containers/hash_tables.h"
 #include "base/gtest_prod_util.h"
 #include "base/macros.h"
 #include "base/memory/linked_ptr.h"
 #include "base/memory/scoped_vector.h"
@@ skipping 20 matching lines @@
 // It handles Presentation API requests coming from Blink / renderer process
 // and delegates the requests to the embedder's media router via
 // PresentationServiceDelegate.
 // An instance of this class tied to a RenderFrameHost and listens to events
 // related to the RFH via implementing WebContentsObserver.
 // This class is instantiated on-demand via Mojo's ConnectToRemoteService
 // from the renderer when the first presentation API request is handled.
 class CONTENT_EXPORT PresentationServiceImpl
     : public NON_EXPORTED_BASE(blink::mojom::PresentationService),
       public WebContentsObserver,
-      public PresentationServiceDelegate::Observer {
+      public PresentationServiceDelegate::Observer,
+      public OffscreenPresentationClient {
  public:
   using NewSessionCallback =
       base::Callback<void(blink::mojom::PresentationSessionInfoPtr,
                           blink::mojom::PresentationErrorPtr)>;
 
   ~PresentationServiceImpl() override;
 
   // Static factory method to create an instance of PresentationServiceImpl.
   // |render_frame_host|: The RFH the instance is associated with.
   // |request|: The instance will be bound to this request. Used for Mojo setup.
@@ skipping 165 matching lines @@
   void ListenForConnectionStateChange(
       const PresentationSessionInfo& connection);
 
   // Passed to embedder's implementation of PresentationServiceDelegate for
   // later invocation when session messages arrive.
   void OnSessionMessages(
       const content::PresentationSessionInfo& session,
       const ScopedVector<PresentationSessionMessage>& messages,
       bool pass_ownership);
 
+  void OnReceiverConnectionAvailable(const content::PresentationSessionInfo&,

[imcheng, 2016/09/28 07:28:37]

nit: add parameter name and add comment for this method.

[zhaobin, 2016/09/29 17:20:45]

Done.

+                                     OffscreenPresentationClient* controller);
+
+  // OffscreenPresentationClient Implementation
+  void SetOffscreenPresentationClient(OffscreenPresentationClient*) override;

[imcheng, 2016/09/28 07:28:37]

nit: add parameter name here and below

[imcheng, 2016/09/28 07:28:37]

AddOffscreenPresentationClient?

[zhaobin, 2016/09/29 17:20:45]

code removed in new patch

[zhaobin, 2016/09/29 17:20:45]

Function has been removed in new patch.

+

[imcheng, 2016/09/28 07:28:37]

rm blank line

[zhaobin, 2016/09/29 17:20:45]

Done.

+  void RemoveOffscreenPresentationClient(OffscreenPresentationClient*) override;
+
   // Associates a JoinSession |callback| with a unique request ID and
   // stores it in a map.
   // Returns a positive value on success.
   int RegisterJoinSessionCallback(const NewSessionCallback& callback);
 
   // Invoked by the embedder's PresentationServiceDelegate when a
   // PresentationConnection's state has changed.
   void OnConnectionStateChanged(
       const PresentationSessionInfo& connection,
       const PresentationConnectionStateChangeInfo& info);
@@ skipping 30 matching lines @@
 
   // There can be only one send message request at a time.
   std::unique_ptr<SendSessionMessageCallback> send_message_callback_;
 
   std::unique_ptr<SessionMessagesCallback> on_session_messages_callback_;
 
   // ID of the RenderFrameHost this object is associated with.
   int render_process_id_;
   int render_frame_id_;
 
+  // Offscreen presentation observer list for current frame.
+  // For controller PSImpl, it contains corresponding receiver PSImpl,
+  // and vise versa.
+  // TODO(zhaobin): support multiple controllers
+  std::set<OffscreenPresentationClient*> offscreen_presentation_observers_;

[imcheng, 2016/09/28 07:28:37]

suggestion: offscreen_presentation_clients_

[imcheng, 2016/09/28 07:28:37]

nit: Place this field before render_process_id_. Please also document ownership
of these clients, i.e., they are not owned by this object.

[zhaobin, 2016/09/29 17:20:45]

object removed in new patch

[zhaobin, 2016/09/29 17:20:45]

object removed in new patch

+
   // NOTE: Weak pointers must be invalidated before all other member variables.
   base::WeakPtrFactory<PresentationServiceImpl> weak_factory_;
 
   DISALLOW_COPY_AND_ASSIGN(PresentationServiceImpl);
 };
 
 }  // namespace content
 
 #endif  // CONTENT_BROWSER_PRESENTATION_PRESENTATION_SERVICE_IMPL_H_