[Presentation API] (MR side) 1-UA: notify receiver page when receiver connection becomes available

chrome/browser/media/router/offscreen_presentation_manager_unittest.cc

+// Copyright 2016 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include <vector>
+
+#include "base/bind.h"
+#include "chrome/browser/media/router/offscreen_presentation_manager.h"
+#include "chrome/browser/media/router/test_helper.h"
+#include "testing/gmock/include/gmock/gmock.h"
+#include "testing/gtest/include/gtest/gtest.h"
+
+using testing::_;
+
+namespace media_router {
+
+namespace {
+const char kPresentationId[] = "presentationId";
+const char kPresentationId2[] = "presentationId2";
+}  // namespace
+
+class MockOffscreenPresentationClient
+    : public content::OffscreenPresentationClient {
+ public:
+  MOCK_METHOD1(SetOffscreenPresentationClient,
+               void(OffscreenPresentationClient*));
+  MOCK_METHOD1(RemoveOffscreenPresentationClient,
+               void(OffscreenPresentationClient*));
+};
+
+class OffscreenPresentationManagerTest : public ::testing::Test {
+ public:
+  OffscreenPresentationManager* manager() { return &manager_; }
+
+  void verifyPresentationsSize(size_t expected);

[imcheng, 2016/09/28 07:28:36]

nit: VerifyNumPresentations

[zhaobin, 2016/09/29 17:20:44]

Done.

+  void verifyControllerSize(size_t expected,

[imcheng, 2016/09/28 07:28:36]

nit: VerifyNumControllers

[zhaobin, 2016/09/29 17:20:44]

Done.

+                            const OffscreenPresentation* presentation);
+
+ private:
+  OffscreenPresentationManager manager_;
+};
+
+class MockReceiverConnectionAvailableCallback {
+ public:
+  MOCK_METHOD2(OnReceiverConnectionAvailable,
+               void(const content::PresentationSessionInfo&,
+                    content::OffscreenPresentationClient*));
+};
+
+void OffscreenPresentationManagerTest::verifyPresentationsSize(

[imcheng, 2016/09/28 07:28:36]

These helper methods can be inlined.

[zhaobin, 2016/09/29 17:20:43]

Done.

+    size_t expected) {
+  EXPECT_EQ(expected, manager_.offscreen_presentations_.size());
+}
+
+void OffscreenPresentationManagerTest::verifyControllerSize(
+    size_t expected,
+    const OffscreenPresentation* presentation) {
+  EXPECT_EQ(expected, presentation->controllers_.size());
+}
+
+TEST_F(OffscreenPresentationManagerTest,
+       RegisterControllerCreateNewPresentation) {

[imcheng, 2016/09/28 07:28:36]

nit: I would just name the test RegisterController

[zhaobin, 2016/09/29 17:20:43]

Done.

+  MockOffscreenPresentationClient controller;
+  manager()->RegisterOffscreenPresentationController(kPresentationId, 1,
+                                                     &controller);
+  verifyPresentationsSize(1);
+}
+
+TEST_F(OffscreenPresentationManagerTest, RegisterOneReceiverDoNothing) {

[imcheng, 2016/09/28 07:28:36]

RegisterReceiver

[zhaobin, 2016/09/29 17:20:44]

Done.

+  MockReceiverConnectionAvailableCallback receiver_callback;
+  manager()->RegisterOffscreenPresentationReceiver(
+      kPresentationId, base::Bind(&MockReceiverConnectionAvailableCallback::
+                                      OnReceiverConnectionAvailable,
+                                  base::Unretained(&receiver_callback)));
+  verifyPresentationsSize(0);
+}
+
+TEST_F(OffscreenPresentationManagerTest, UnregisterControllerNoCrash) {

[imcheng, 2016/09/28 07:28:36]

UnregisterNonexistentController

[zhaobin, 2016/09/29 17:20:44]

Done.

+  MockOffscreenPresentationClient controller;

[imcheng, 2016/09/28 07:28:36]

Unused?

[zhaobin, 2016/09/29 17:20:44]

Done.

+  manager()->UnregisterOffscreenPresentationController(kPresentationId, 1);
+  verifyPresentationsSize(0);
+}
+
+TEST_F(OffscreenPresentationManagerTest, UnregisterReceiverNoCrash) {

[imcheng, 2016/09/28 07:28:36]

UnregisterNonexistentReceiver

[zhaobin, 2016/09/29 17:20:43]

Done.

+  manager()->UnregisterOffscreenPresentationReceiver(kPresentationId);
+  verifyPresentationsSize(0);
+}
+
+TEST_F(OffscreenPresentationManagerTest,
+       RegisterControllerCreatePresentationWithTwoControllers) {

[imcheng, 2016/09/28 07:28:36]

RegisterMultipleControllersSamePresentation ?

[zhaobin, 2016/09/29 17:20:43]

Done.

+  MockOffscreenPresentationClient controller1;
+  manager()->RegisterOffscreenPresentationController(kPresentationId, 1,
+                                                     &controller1);
+  MockOffscreenPresentationClient controller2;
+  manager()->RegisterOffscreenPresentationController(kPresentationId, 2,
+                                                     &controller2);
+  verifyPresentationsSize(1);
+}
+
+TEST_F(OffscreenPresentationManagerTest,
+       RegisterControllerCreateTwoPresentations) {

[imcheng, 2016/09/28 07:28:36]

RegisterMultipleControllersDifferentPresentations

[zhaobin, 2016/09/29 17:20:44]

Done.

+  MockOffscreenPresentationClient controller1;
+  manager()->RegisterOffscreenPresentationController(kPresentationId, 1,
+                                                     &controller1);
+  MockOffscreenPresentationClient controller2;
+  manager()->RegisterOffscreenPresentationController(kPresentationId2, 1,
+                                                     &controller2);
+  verifyPresentationsSize(2);
+}
+
+TEST_F(OffscreenPresentationManagerTest,
+       RegisterControllerAndReceiverFireOnConnectionAvailable) {

[imcheng, 2016/09/28 07:28:36]

RegisterControllerThenReceiverInvokesCallback ?

[zhaobin, 2016/09/29 17:20:44]

Done.

+  MockOffscreenPresentationClient controller;
+  MockReceiverConnectionAvailableCallback receiver_callback;
+
+  verifyPresentationsSize(0);
+  EXPECT_CALL(receiver_callback, OnReceiverConnectionAvailable(_, &controller));

[imcheng, 2016/09/28 07:28:36]

Move this EXPECT to just before RegisterOffscreenPresentationReceiver. Same for
below.

[zhaobin, 2016/09/29 17:20:44]

Done.

+
+  manager()->RegisterOffscreenPresentationController(kPresentationId, 1,
+                                                     &controller);
+  manager()->RegisterOffscreenPresentationReceiver(
+      kPresentationId, base::Bind(&MockReceiverConnectionAvailableCallback::
+                                      OnReceiverConnectionAvailable,
+                                  base::Unretained(&receiver_callback)));
+}
+
+TEST_F(OffscreenPresentationManagerTest, RegisterUnregisterController) {

[imcheng, 2016/09/28 07:28:36]

Combine this case with RegisterController

[zhaobin, 2016/09/29 17:20:43]

Done.

+  MockOffscreenPresentationClient controller;
+  manager()->RegisterOffscreenPresentationController(kPresentationId, 1,
+                                                     &controller);
+  manager()->UnregisterOffscreenPresentationController(kPresentationId, 1);
+  verifyPresentationsSize(0);
+}
+
+TEST_F(OffscreenPresentationManagerTest, UnregisterReceiverOnly) {

[imcheng, 2016/09/28 07:28:36]

UnregisterReceiverFromConnectedPresentation

[zhaobin, 2016/09/29 17:20:44]

Done.

+  MockOffscreenPresentationClient controller;
+  MockReceiverConnectionAvailableCallback receiver_callback;
+  EXPECT_CALL(receiver_callback, OnReceiverConnectionAvailable(_, &controller));
+
+  manager()->RegisterOffscreenPresentationController(kPresentationId, 1,
+                                                     &controller);
+  manager()->RegisterOffscreenPresentationReceiver(
+      kPresentationId, base::Bind(&MockReceiverConnectionAvailableCallback::
+                                      OnReceiverConnectionAvailable,
+                                  base::Unretained(&receiver_callback)));
+  manager()->UnregisterOffscreenPresentationReceiver(kPresentationId);
+
+  verifyPresentationsSize(0);
+}
+
+TEST_F(OffscreenPresentationManagerTest, UnregisterControllerOnly) {

[imcheng, 2016/09/28 07:28:36]

UnregisterControllerFromConnectedPresentation

[zhaobin, 2016/09/29 17:20:44]

Done.

+  MockOffscreenPresentationClient controller;
+  MockReceiverConnectionAvailableCallback receiver_callback;
+  EXPECT_CALL(receiver_callback, OnReceiverConnectionAvailable(_, &controller));
+
+  manager()->RegisterOffscreenPresentationController(kPresentationId, 1,
+                                                     &controller);
+  manager()->RegisterOffscreenPresentationReceiver(
+      kPresentationId, base::Bind(&MockReceiverConnectionAvailableCallback::
+                                      OnReceiverConnectionAvailable,
+                                  base::Unretained(&receiver_callback)));
+
+  manager()->UnregisterOffscreenPresentationController(kPresentationId, 1);
+  verifyPresentationsSize(1);
+}
+
+TEST_F(OffscreenPresentationManagerTest, UnregisterReceiverController) {
+  MockOffscreenPresentationClient controller;
+  MockReceiverConnectionAvailableCallback receiver_callback;
+  EXPECT_CALL(receiver_callback, OnReceiverConnectionAvailable(_, &controller));
+
+  manager()->RegisterOffscreenPresentationController(kPresentationId, 1,
+                                                     &controller);
+  manager()->RegisterOffscreenPresentationReceiver(
+      kPresentationId, base::Bind(&MockReceiverConnectionAvailableCallback::
+                                      OnReceiverConnectionAvailable,
+                                  base::Unretained(&receiver_callback)));
+
+  manager()->UnregisterOffscreenPresentationReceiver(kPresentationId);
+  manager()->UnregisterOffscreenPresentationController(kPresentationId, 1);
+
+  verifyPresentationsSize(0);
+}
+
+TEST_F(OffscreenPresentationManagerTest, UnregisterControllerReceiver) {
+  MockOffscreenPresentationClient controller;
+  MockReceiverConnectionAvailableCallback receiver_callback;
+  EXPECT_CALL(receiver_callback, OnReceiverConnectionAvailable(_, &controller));
+
+  manager()->RegisterOffscreenPresentationController(kPresentationId, 1,
+                                                     &controller);
+  manager()->RegisterOffscreenPresentationReceiver(
+      kPresentationId, base::Bind(&MockReceiverConnectionAvailableCallback::
+                                      OnReceiverConnectionAvailable,
+                                  base::Unretained(&receiver_callback)));
+
+  manager()->UnregisterOffscreenPresentationController(kPresentationId, 1);
+  manager()->UnregisterOffscreenPresentationReceiver(kPresentationId);
+
+  verifyPresentationsSize(0);
+}
+
+TEST_F(OffscreenPresentationManagerTest,
+       RegisterTwoControllersThenReceiverFireOnConnectionAvailableTwice) {
+  MockOffscreenPresentationClient controller;
+  manager()->RegisterOffscreenPresentationController(kPresentationId, 1,
+                                                     &controller);
+  MockOffscreenPresentationClient controller2;
+  manager()->RegisterOffscreenPresentationController(kPresentationId, 2,
+                                                     &controller2);
+
+  MockReceiverConnectionAvailableCallback receiver_callback;
+  EXPECT_CALL(receiver_callback, OnReceiverConnectionAvailable(_, &controller));
+  EXPECT_CALL(receiver_callback,
+              OnReceiverConnectionAvailable(_, &controller2));
+
+  manager()->RegisterOffscreenPresentationReceiver(
+      kPresentationId, base::Bind(&MockReceiverConnectionAvailableCallback::
+                                      OnReceiverConnectionAvailable,
+                                  base::Unretained(&receiver_callback)));
+}
+
+TEST_F(OffscreenPresentationManagerTest,
+       RegisterControllerReceiverConontrollerFireOnConnectionAvailableTwice) {
+  MockOffscreenPresentationClient controller;
+  manager()->RegisterOffscreenPresentationController(kPresentationId, 1,
+                                                     &controller);
+  MockReceiverConnectionAvailableCallback receiver_callback;
+  EXPECT_CALL(receiver_callback, OnReceiverConnectionAvailable(_, &controller));
+  manager()->RegisterOffscreenPresentationReceiver(
+      kPresentationId, base::Bind(&MockReceiverConnectionAvailableCallback::
+                                      OnReceiverConnectionAvailable,
+                                  base::Unretained(&receiver_callback)));
+
+  MockOffscreenPresentationClient controller2;
+  EXPECT_CALL(receiver_callback,
+              OnReceiverConnectionAvailable(_, &controller2));
+  manager()->RegisterOffscreenPresentationController(kPresentationId, 2,
+                                                     &controller2);
+}
+
+TEST_F(OffscreenPresentationManagerTest,
+       OnePresentationUnregisterFirstController) {
+  MockOffscreenPresentationClient controller;
+  manager()->RegisterOffscreenPresentationController(kPresentationId, 1,
+                                                     &controller);
+  MockOffscreenPresentationClient controller2;
+  manager()->RegisterOffscreenPresentationController(kPresentationId, 2,
+                                                     &controller2);
+  MockReceiverConnectionAvailableCallback receiver_callback;
+  EXPECT_CALL(receiver_callback, OnReceiverConnectionAvailable(_, _)).Times(2);
+
+  manager()->RegisterOffscreenPresentationReceiver(
+      kPresentationId, base::Bind(&MockReceiverConnectionAvailableCallback::
+                                      OnReceiverConnectionAvailable,
+                                  base::Unretained(&receiver_callback)));
+  manager()->UnregisterOffscreenPresentationController(kPresentationId, 1);
+  manager()->UnregisterOffscreenPresentationController(kPresentationId, 2);
+
+  verifyPresentationsSize(1);
+}
+
+TEST_F(OffscreenPresentationManagerTest, TwoPresentations) {
+  MockOffscreenPresentationClient controller;
+  manager()->RegisterOffscreenPresentationController(kPresentationId, 1,
+                                                     &controller);
+  MockReceiverConnectionAvailableCallback receiver_callback;
+  EXPECT_CALL(receiver_callback, OnReceiverConnectionAvailable(_, &controller));
+  manager()->RegisterOffscreenPresentationReceiver(
+      kPresentationId, base::Bind(&MockReceiverConnectionAvailableCallback::
+                                      OnReceiverConnectionAvailable,
+                                  base::Unretained(&receiver_callback)));
+  MockOffscreenPresentationClient controller2;
+  manager()->RegisterOffscreenPresentationController(kPresentationId2, 2,
+                                                     &controller2);
+  MockReceiverConnectionAvailableCallback receiver_callback2;
+  EXPECT_CALL(receiver_callback2,
+              OnReceiverConnectionAvailable(_, &controller2));
+  manager()->RegisterOffscreenPresentationReceiver(
+      kPresentationId2, base::Bind(&MockReceiverConnectionAvailableCallback::
+                                       OnReceiverConnectionAvailable,
+                                   base::Unretained(&receiver_callback2)));
+
+  verifyPresentationsSize(2);
+
+  manager()->UnregisterOffscreenPresentationReceiver(kPresentationId2);
+  verifyPresentationsSize(1);
+}
+
+}  // namespace media_router