Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1935)

Unified Diff: net/cert/internal/verify_certificate_chain.h

Issue 2342973003: Remove the externs for VerifyCertificateChain()'s errors. (Closed)
Patch Set: Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | net/cert/internal/verify_certificate_chain.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/cert/internal/verify_certificate_chain.h
diff --git a/net/cert/internal/verify_certificate_chain.h b/net/cert/internal/verify_certificate_chain.h
index b468412eebcfa41ddd9bfeb56f1f669236de8a72..d1ea57e05750b4ea3c5df0cb690a9d40b5fde789 100644
--- a/net/cert/internal/verify_certificate_chain.h
+++ b/net/cert/internal/verify_certificate_chain.h
@@ -75,31 +75,6 @@ NET_EXPORT bool VerifyCertificateChain(const ParsedCertificateList& certs,
const der::GeneralizedTime& time,
CertErrors* errors) WARN_UNUSED_RESULT;
-// -----------------------------------------------
-// Errors/Warnings set by VerifyCertificateChain
-// -----------------------------------------------
-
-namespace verify_certificate_chain_errors {
-
-// TODO(eroman): Document each of these and their parameters.
-extern CertErrorId kSignatureAlgorithmMismatch;
-extern CertErrorId kInvalidOrUnsupportedSignatureAlgorithm;
-extern CertErrorId kChainIsEmpty;
-extern CertErrorId kUnconsumedCriticalExtension;
-extern CertErrorId kTargetCertInconsistentCaBits;
-extern CertErrorId kKeyCertSignBitNotSet;
-extern CertErrorId kMaxPathLengthViolated;
-extern CertErrorId kBasicConstraintsIndicatesNotCa;
-extern CertErrorId kMissingBasicConstraints;
-extern CertErrorId kNotPermittedByNameConstraints;
-extern CertErrorId kSubjectDoesNotMatchIssuer;
-extern CertErrorId kVerifySignedDataFailed;
-extern CertErrorId kValidityFailedNotAfter;
-extern CertErrorId kValidityFailedNotBefore;
-extern CertErrorId kSignatureAlgorithmsDifferentEncoding;
-
-} // namespace verify_certificate_chain_errors
-
} // namespace net
#endif // NET_CERT_INTERNAL_VERIFY_CERTIFICATE_CHAIN_H_
« no previous file with comments | « no previous file | net/cert/internal/verify_certificate_chain.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698