Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(484)

Issue 2342973003: Remove the externs for VerifyCertificateChain()'s errors. (Closed)

Created:
4 years, 3 months ago by eroman
Modified:
4 years, 3 months ago
Reviewers:
mattm
CC:
chromium-reviews, cbentzel+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove the externs for VerifyCertificateChain()'s errors. These are not ready to be exposed as API yet, as the structure and types of errors is still being adjusted. They aren't needed for testing either, since it is using text comparisons. BUG=634443 Committed: https://crrev.com/1bc2ed3679476ce691fd1fe66dfd3f1b9d00090d Cr-Commit-Position: refs/heads/master@{#419300}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+32 lines, -59 lines) Patch
M net/cert/internal/verify_certificate_chain.h View 1 chunk +0 lines, -25 lines 0 comments Download
M net/cert/internal/verify_certificate_chain.cc View 2 chunks +32 lines, -34 lines 0 comments Download

Messages

Total messages: 12 (7 generated)
eroman
4 years, 3 months ago (2016-09-16 01:30:46 UTC) #2
mattm
lgtm
4 years, 3 months ago (2016-09-16 21:25:34 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2342973003/1
4 years, 3 months ago (2016-09-16 22:19:15 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-09-16 22:26:20 UTC) #10
commit-bot: I haz the power
4 years, 3 months ago (2016-09-16 22:29:17 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/1bc2ed3679476ce691fd1fe66dfd3f1b9d00090d
Cr-Commit-Position: refs/heads/master@{#419300}

Powered by Google App Engine
This is Rietveld 408576698