Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(133)

Unified Diff: media/blink/cdm_result_promise_helper.cc

Issue 2342953002: Update EME errors to use TypeError (Closed)
Patch Set: createDOMException Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: media/blink/cdm_result_promise_helper.cc
diff --git a/media/blink/cdm_result_promise_helper.cc b/media/blink/cdm_result_promise_helper.cc
index c96121a0fed7aac94bb58165df4f8112e9b12b74..e04d0135c50aca9d48d13543da800e56703a4c16 100644
--- a/media/blink/cdm_result_promise_helper.cc
+++ b/media/blink/cdm_result_promise_helper.cc
@@ -39,15 +39,18 @@ blink::WebContentDecryptionModuleException ConvertCdmException(
case MediaKeys::INVALID_STATE_ERROR:
return blink::WebContentDecryptionModuleExceptionInvalidStateError;
case MediaKeys::INVALID_ACCESS_ERROR:
- return blink::WebContentDecryptionModuleExceptionInvalidAccessError;
+ // TODO(jrummell): Since InvalidAccess is not returned, thus should be
+ // renamed to TYPE_ERROR. http://crbug.com/570216#c11.
xhwang 2016/10/17 23:13:55 nit: move this to above the "case"?
jrummell 2016/10/18 00:50:39 Done.
+ return blink::WebContentDecryptionModuleExceptionTypeError;
case MediaKeys::QUOTA_EXCEEDED_ERROR:
return blink::WebContentDecryptionModuleExceptionQuotaExceededError;
case MediaKeys::UNKNOWN_ERROR:
return blink::WebContentDecryptionModuleExceptionUnknownError;
case MediaKeys::CLIENT_ERROR:
- return blink::WebContentDecryptionModuleExceptionClientError;
case MediaKeys::OUTPUT_ERROR:
- return blink::WebContentDecryptionModuleExceptionOutputError;
+ // These are deprecated, and should be removed.
+ // http://crbug.com/570216#c11.
xhwang 2016/10/17 23:13:55 ditto
jrummell 2016/10/18 00:50:39 Done.
+ break;
}
NOTREACHED();
return blink::WebContentDecryptionModuleExceptionUnknownError;

Powered by Google App Engine
This is Rietveld 408576698