Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(197)

Unified Diff: runtime/observatory/lib/src/elements/helpers/any_ref.dart

Issue 2342943002: Observatory: Fix instance view of lists. (Closed)
Patch Set: Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | runtime/observatory/lib/src/elements/instance_ref.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/observatory/lib/src/elements/helpers/any_ref.dart
diff --git a/runtime/observatory/lib/src/elements/helpers/any_ref.dart b/runtime/observatory/lib/src/elements/helpers/any_ref.dart
index 704e1a5c990d669f12a9cc00913c0545d6d2fe0d..a15133abc222e5e499ee531e6b5d290e8d4d71c6 100644
--- a/runtime/observatory/lib/src/elements/helpers/any_ref.dart
+++ b/runtime/observatory/lib/src/elements/helpers/any_ref.dart
@@ -28,8 +28,11 @@ import 'package:observatory/src/elements/unknown_ref.dart';
Element anyRef(M.IsolateRef isolate, ref,
M.InstanceRepository instances, {RenderingQueue queue}) {
if (ref is M.Guarded) {
- return anyRef(isolate, ref.asSentinel ?? ref.asValue, instances,
- queue: queue);
+ if (ref.isSentinel) {
+ return anyRef(isolate, ref.asSentinel, instances, queue: queue);
+ } else {
+ return anyRef(isolate, ref.asValue, instances, queue: queue);
+ }
} else if (ref is M.ObjectRef) {
if (ref is M.ClassRef) {
return new ClassRefElement(isolate, ref, queue: queue);
@@ -72,5 +75,5 @@ Element anyRef(M.IsolateRef isolate, ref,
} else if (ref is M.Sentinel) {
return new SentinelValueElement(ref, queue: queue);
}
- throw new Exception('Unknown runtimeType (${ref.runtimeType})');
+ throw new Exception('Unknown ref type (${ref.runtimeType})');
}
« no previous file with comments | « no previous file | runtime/observatory/lib/src/elements/instance_ref.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698