Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(599)

Side by Side Diff: runtime/observatory/lib/src/elements/instance_view.dart

Issue 2342943002: Observatory: Fix instance view of lists. (Closed)
Patch Set: Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « runtime/observatory/lib/src/elements/instance_ref.dart ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2013, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2013, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 library instance_view_element; 5 library instance_view_element;
6 6
7 import 'dart:async'; 7 import 'dart:async';
8 import 'dart:html'; 8 import 'dart:html';
9 import 'package:observatory/models.dart' as M; 9 import 'package:observatory/models.dart' as M;
10 import 'package:observatory/src/elements/class_ref.dart'; 10 import 'package:observatory/src/elements/class_ref.dart';
(...skipping 400 matching lines...) Expand 10 before | Expand all | Expand 10 after
411 int i = 0; 411 int i = 0;
412 members.add(new DivElement()..classes = ['memberItem'] 412 members.add(new DivElement()..classes = ['memberItem']
413 ..children = [ 413 ..children = [
414 new DivElement()..classes = ['memberName'] 414 new DivElement()..classes = ['memberName']
415 ..text = 'elements (${_instance.length})', 415 ..text = 'elements (${_instance.length})',
416 new DivElement()..classes = ['memberValue'] 416 new DivElement()..classes = ['memberValue']
417 ..children = [ 417 ..children = [
418 new CurlyBlockElement( 418 new CurlyBlockElement(
419 expanded: elements.length <= 100, 419 expanded: elements.length <= 100,
420 queue: _r.queue) 420 queue: _r.queue)
421 ..children = [ 421 ..content = [
422 new DivElement()..classes = ['memberList'] 422 new DivElement()..classes = ['memberList']
423 ..children = elements.map((e) => 423 ..children = elements.map((element) =>
424 new DivElement()..classes = ['memberItem'] 424 new DivElement()..classes = ['memberItem']
425 ..children = [ 425 ..children = [
426 new DivElement()..classes = ['memberName'] 426 new DivElement()..classes = ['memberName']
427 ..text = '[ ${i++} ]', 427 ..text = '[ ${i++} ]',
428 new DivElement()..classes = ['memberValue'] 428 new DivElement()..classes = ['memberValue']
429 ..children = [ 429 ..children = [
430 anyRef(_isolate, e, _instances, 430 anyRef(_isolate, element, _instances,
431 queue: _r.queue) 431 queue: _r.queue)
432 ] 432 ]
433 ]).toList() 433 ]).toList()
434 ] 434 ]
435 ] 435 ]
436 ]); 436 ]);
437 if (_instance.length != elements.length) { 437 if (_instance.length != elements.length) {
438 members.add(new DivElement()..classes = ['memberItem'] 438 members.add(new DivElement()..classes = ['memberItem']
439 ..children = [ 439 ..children = [
440 new DivElement()..classes = ['memberName'] 440 new DivElement()..classes = ['memberName']
(...skipping 240 matching lines...) Expand 10 before | Expand all | Expand 10 after
681 681
682 Future _toggleBreakpoint() async { 682 Future _toggleBreakpoint() async {
683 if (_instance.activationBreakpoint == null) { 683 if (_instance.activationBreakpoint == null) {
684 await _breakpoints.addOnActivation(_isolate, _instance); 684 await _breakpoints.addOnActivation(_isolate, _instance);
685 } else { 685 } else {
686 await _breakpoints.remove(_isolate, _instance.activationBreakpoint); 686 await _breakpoints.remove(_isolate, _instance.activationBreakpoint);
687 } 687 }
688 await _refresh(); 688 await _refresh();
689 } 689 }
690 } 690 }
OLDNEW
« no previous file with comments | « runtime/observatory/lib/src/elements/instance_ref.dart ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698