Observatory: Fix instance view of lists.

runtime/observatory/lib/src/elements/instance_ref.dart

 // Copyright (c) 2013, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 import 'dart:html';
 import 'dart:async';
 import 'package:observatory/models.dart' as M;
 import 'package:observatory/src/elements/curly_block.dart';
 import 'package:observatory/src/elements/field_ref.dart';
 import 'package:observatory/src/elements/helpers/any_ref.dart';
@@ skipping 226 matching lines @@
       return [new SpanElement()..text = 'Loading...'];
     }
     switch (_instance.kind) {
       case M.InstanceKind.plainInstance:
         return _loadedInstance.fields.map((f) =>
           new DivElement()
             ..children = [
               new FieldRefElement(_isolate, f.decl, _instances,
                   queue: _r.queue),
               new SpanElement()..text = ' = ',
-              f.value.isSentinel
-                ? new SentinelValueElement(f.value.asSentinel, queue: _r.queue)
-                : new InstanceRefElement(_isolate, f.value.asValue, _instances,
-                    queue: _r.queue)
+              anyRef(_isolate, f.value, _instances, queue: _r.queue)
             ]).toList();
       case M.InstanceKind.list:
         var index = 0;
-        return _loadedInstance.elements.map((e) =>
+        return _loadedInstance.elements.map((element) =>
           new DivElement()
             ..children = [
               new SpanElement()..text = '[ ${index++} ] : ',
-              e.isSentinel
-                ? new SentinelValueElement(e.asSentinel, queue: _r.queue)
-                : anyRef(_isolate, e.asValue, _instances, queue: _r.queue)
-                // should be:
-                // new InstanceRefElement(_isolate, e.asValue, _instances,
-                //                        queue: _r.queue)
-                // in some situations we obtain values that are not InstanceRef.
+              anyRef(_isolate, element, _instances, queue: _r.queue)
             ]).toList()..addAll(_createShowMoreButton());
       case M.InstanceKind.map:
-        return _loadedInstance.associations.map((a) =>
+        return _loadedInstance.associations.map((association) =>
           new DivElement()
             ..children = [
               new SpanElement()..text = '[ ',
-              a.key.isSentinel
-                ? new SentinelValueElement(a.key.asSentinel, queue: _r.queue)
-                : new InstanceRefElement(_isolate, a.key.asValue, _instances,
-                    queue: _r.queue),
+              anyRef(_isolate, association.key, _instances, queue: _r.queue),
               new SpanElement()..text = ' ] : ',
-              a.value.isSentinel
-                ? new SentinelValueElement(a.value.asSentinel, queue: _r.queue)
-                : new InstanceRefElement(_isolate, a.value.asValue, _instances,
-                    queue: _r.queue)
+              anyRef(_isolate, association.value, _instances, queue: _r.queue)
             ]).toList()..addAll(_createShowMoreButton());
       case M.InstanceKind.uint8ClampedList:
       case M.InstanceKind.uint8List:
       case M.InstanceKind.uint16List:
       case M.InstanceKind.uint32List:
       case M.InstanceKind.uint64List:
       case M.InstanceKind.int8List:
       case M.InstanceKind.int16List:
       case M.InstanceKind.int32List:
       case M.InstanceKind.int64List:
@@ skipping 20 matching lines @@
           new BRElement(),
           new SpanElement()..text = '<value> : ',
           new InstanceRefElement(_isolate, _loadedInstance.value, _instances,
             queue: _r.queue),
         ];
       default:
         return [];
     }
   }
 }