presubmit_canned_checks.py - Issue 234293002: Add file:// case in presubmit_canned_checks.CheckLongLines

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: presubmit_canned_checks.py

Issue 234293002: Add file:// case in presubmit_canned_checks.CheckLongLines (Closed) Base URL: https://chromium.googlesource.com/chromium/tools/depot_tools.git@master

Patch Set: Created 6 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: presubmit_canned_checks.py

diff --git a/presubmit_canned_checks.py b/presubmit_canned_checks.py

index 878ee70a68ff71b12bed82dd3082a90cae7219fd..fc1afbc473597d0842442a318edb248330bf7700 100644

--- a/presubmit_canned_checks.py

+++ b/presubmit_canned_checks.py

@@ -359,7 +359,7 @@ def CheckLongLines(input_api, output_api, maxlen, source_file_filter=None):

return False

return (

- any((url in line) for url in ('http://', 'https://')) or

+ any((url in line) for url in ('http://', 'https://', 'file://')) or

M-A Ruel 2014/04/10 23:53:58 Keep ordered. Adding at the end of a list is not a

input_api.re.match(

r'.*[A-Za-z][A-Za-z_0-9]{%d,}.*' % long_symbol, line))

« no previous file with comments | « no previous file | tests/presubmit_unittest.py » ('j') | no next file with comments »