Add file:// case in presubmit_canned_checks.CheckLongLines

presubmit_canned_checks.py

 # Copyright (c) 2012 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 """Generic presubmit checks that can be reused by other presubmit checks."""
 
 import os as _os
 _HERE = _os.path.dirname(_os.path.abspath(__file__))
 
 
@@ skipping 341 matching lines @@
     extra_maxlen = file_maxlen * 3 / 2
 
     line_len = len(line)
     if line_len <= file_maxlen:
       return True
 
     if line_len > extra_maxlen:
       return False
 
     return (
-        any((url in line) for url in ('http://', 'https://')) or
+      any((url in line) for url in ('http://', 'https://', 'file://')) or

[M-A Ruel, 2014/04/10 23:53:58]

Keep ordered. Adding at the end of a list is not always the best option. :)

         input_api.re.match(
           r'.*[A-Za-z][A-Za-z_0-9]{%d,}.*' % long_symbol, line))
 
   def format_error(filename, line_num, line):
     return '%s, line %s, %s chars' % (filename, line_num, len(line))
 
   errors = _FindNewViolationsOfRule(no_long_lines, input_api,
                                     source_file_filter,
                                     error_formatter=format_error)
   if errors:
@@ skipping 688 matching lines @@
 def CheckPatchFormatted(input_api, output_api):
   import git_cl
   cmd = ['cl', 'format', '--dry-run', input_api.PresubmitLocalPath()]
   code, _ = git_cl.RunGitWithCode(cmd, suppress_stderr=True)
   if code == 2:
     return [output_api.PresubmitPromptWarning(
       'Your patch is not formatted, please run git cl format.')]
   # As this is just a warning, ignore all other errors if the user
   # happens to have a broken clang-format, doesn't use git, etc etc.
   return []