Issue 234293002: Add file:// case in presubmit_canned_checks.CheckLongLines

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 234293002: Add file:// case in presubmit_canned_checks.CheckLongLines (Closed)

Created:
6 years, 8 months ago by nednguyen

Modified:
6 years, 8 months ago

Reviewers:
Dirk Pranke, dtu, M-A Ruel

CC:
chromium-reviews, Dirk Pranke, cmp-cc_chromium.org, M-A Ruel, iannucci+depot_tools_chromium.org, ilevy-cc_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/tools/depot_tools.git@master

Visibility:
Public.

More Reviews

Description

Add file:// case in presubmit_canned_checks.CheckLongLines BUG= Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=263142

Patch Set 2 : Keep the list in order #

Created: 6 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+12 lines, -1 line)			Patch
	M	presubmit_canned_checks.py	View	1	1 chunk	+1 line, -1 line	0 comments	Download
	M	tests/presubmit_unittest.py	View		1 chunk	+11 lines, -0 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

M-A Ruel

lgtm https://codereview.chromium.org/234293002/diff/1/presubmit_canned_checks.py File presubmit_canned_checks.py (right): https://codereview.chromium.org/234293002/diff/1/presubmit_canned_checks.py#newcode362 presubmit_canned_checks.py:362: any((url in line) for url in ('http://', 'https://', ...

6 years, 8 months ago (2014-04-10 23:53:57 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/nednguyen@google.com/234293002/20001

6 years, 8 months ago (2014-04-11 00:12:00 UTC) #5

Message was sent while issue was closed.

Change committed as 263142

Expand Messages | Collapse Messages

Issue 234293002: Add file:// case in presubmit_canned_checks.CheckLongLines (Closed)

Description

Patch Set 1 #

Patch Set 2 : Keep the list in order #

Messages