Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(35)

Issue 2342913002: [Chromecast] Don't DCHECK the result of snd_pcm_status_get_avail (Closed)

Created:
4 years, 3 months ago by kmackay
Modified:
4 years, 3 months ago
Reviewers:
slan, halliwell
CC:
chromium-reviews, alokp+watch_chromium.org, lcwu+watch_chromium.org, halliwell+watch_chromium.org, feature-media-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Chromecast] Don't DCHECK the result of snd_pcm_status_get_avail The result of snd_pcm_status_get_avail() can be nonsensical if the PCM handle is in the XRUN state. BUG= internal b/31506355 Committed: https://crrev.com/bbcc2d8f1a9bf354f22ec7821fd750e32691d19a Cr-Commit-Position: refs/heads/master@{#418909}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -3 lines) Patch
M chromecast/media/cma/backend/alsa/stream_mixer_alsa.cc View 2 chunks +2 lines, -3 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
kmackay
4 years, 3 months ago (2016-09-15 17:15:00 UTC) #2
halliwell
On 2016/09/15 17:15:00, kmackay wrote: lgtm
4 years, 3 months ago (2016-09-15 17:21:11 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2342913002/1
4 years, 3 months ago (2016-09-15 17:24:30 UTC) #5
slan
lgtm
4 years, 3 months ago (2016-09-15 18:00:47 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-09-15 18:31:19 UTC) #7
commit-bot: I haz the power
4 years, 3 months ago (2016-09-15 18:34:22 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/bbcc2d8f1a9bf354f22ec7821fd750e32691d19a
Cr-Commit-Position: refs/heads/master@{#418909}

Powered by Google App Engine
This is Rietveld 408576698