Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(32)

Issue 2342903004: Adding security owners for content/shell/common/*_messages*.h (Closed)

Created:
4 years, 3 months ago by Łukasz Anforowicz
Modified:
4 years, 3 months ago
Reviewers:
nasko, dcheng
CC:
chromium-reviews, Peter Beverloo, mlamouri+watch-content_chromium.org, jam, darin-cc_chromium.org, jochen+watch_chromium.org, dcheng
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Adding security owners for content/shell/common/*_messages*.h This CL avoids future presubmit violations like the one quoted below: ** Presubmit Warnings ** Found changes to IPC files without a security OWNER! *************** content/shell/common/OWNERS is missing the following lines: per-file *_messages*.h=set noparent per-file *_messages*.h=file://ipc/SECURITY_OWNERS for changed files: content/shell/common/shell_messages.h *************** The presubmit checks performed above were added in r400748. BUG=611905 Committed: https://crrev.com/cca690a0484a12b084313905841dc17e71ca11bc Cr-Commit-Position: refs/heads/master@{#419285}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+-1 lines, --1 lines) Patch
A + content/shell/common/OWNERS View 0 chunks +-1 lines, --1 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
Łukasz Anforowicz
nasko@, can you take a look please? (as both a //content OWNER and a security/IPC ...
4 years, 3 months ago (2016-09-16 19:11:20 UTC) #2
dcheng
rs lgtm
4 years, 3 months ago (2016-09-16 19:16:12 UTC) #4
nasko
LGTM
4 years, 3 months ago (2016-09-16 20:44:10 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2342903004/1
4 years, 3 months ago (2016-09-16 20:52:21 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-09-16 21:44:58 UTC) #8
commit-bot: I haz the power
4 years, 3 months ago (2016-09-16 21:47:00 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/cca690a0484a12b084313905841dc17e71ca11bc
Cr-Commit-Position: refs/heads/master@{#419285}

Powered by Google App Engine
This is Rietveld 408576698