Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(503)

Issue 2342903003: Keeping asserts in release. (Closed)

Created:
4 years, 3 months ago by cblume
Modified:
4 years, 3 months ago
Reviewers:
bsalomon, jbauman
CC:
reviews_skia.org
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Keeping asserts in release. We have a bug that is showing up occasionally in Canary. I want to see if these asserts could provide insight into why the bug happens. BUG=643845 GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2342903003 Committed: https://skia.googlesource.com/skia/+/94ddf54a6da1b4c65beaf1a32ac1718959b0709c

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -7 lines) Patch
M src/image/SkImage_Gpu.cpp View 3 chunks +6 lines, -7 lines 0 comments Download

Messages

Total messages: 8 (4 generated)
cblume
PTAL
4 years, 3 months ago (2016-09-16 00:44:19 UTC) #3
bsalomon
lgtm
4 years, 3 months ago (2016-09-16 13:27:49 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2342903003/1
4 years, 3 months ago (2016-09-16 16:52:30 UTC) #6
commit-bot: I haz the power
4 years, 3 months ago (2016-09-16 17:07:35 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/94ddf54a6da1b4c65beaf1a32ac1718959b0709c

Powered by Google App Engine
This is Rietveld 408576698