Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(126)

Issue 2342903002: Remove calls to deprecated MessageLoop methods from message_loop_unittest.cc. (Closed)

Created:
4 years, 3 months ago by fdoray
Modified:
4 years, 3 months ago
Reviewers:
Mark Mentovai
CC:
chromium-reviews, sadrul
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove calls to deprecated MessageLoop methods from message_loop_unittest.cc. This CL removes calls to MessageLoop::Post(Delayed)Task from message_loop_unittest.cc BUG=616447 Committed: https://crrev.com/a93afc284a6b18b1df8c363c2700ec32f69b56af Cr-Commit-Position: refs/heads/master@{#418925}

Patch Set 1 #

Patch Set 2 : fix build error #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -2 lines) Patch
M base/message_loop/message_loop_unittest.cc View 1 1 chunk +3 lines, -2 lines 0 comments Download

Messages

Total messages: 13 (6 generated)
fdoray
PTAL
4 years, 3 months ago (2016-09-15 17:07:18 UTC) #2
Mark Mentovai
LGTM
4 years, 3 months ago (2016-09-15 17:26:53 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2342903002/1
4 years, 3 months ago (2016-09-15 17:28:48 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: android_compile_dbg on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_compile_dbg/builds/129645)
4 years, 3 months ago (2016-09-15 17:35:44 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2342903002/20001
4 years, 3 months ago (2016-09-15 18:07:51 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 3 months ago (2016-09-15 18:59:30 UTC) #11
commit-bot: I haz the power
4 years, 3 months ago (2016-09-15 19:01:58 UTC) #13
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/a93afc284a6b18b1df8c363c2700ec32f69b56af
Cr-Commit-Position: refs/heads/master@{#418925}

Powered by Google App Engine
This is Rietveld 408576698