Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(60)

Issue 2342893002: Issue 27044. Summarize configurations of imports and exports, AST based. (Closed)

Created:
4 years, 3 months ago by scheglov
Modified:
4 years, 3 months ago
Reviewers:
Paul Berry
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 2

Patch Set 2 : No equality test means '== true'. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+339 lines, -7 lines) Patch
M pkg/analyzer/lib/src/summary/format.dart View 1 21 chunks +220 lines, -3 lines 0 comments Download
M pkg/analyzer/lib/src/summary/format.fbs View 1 Binary file 0 comments Download
M pkg/analyzer/lib/src/summary/idl.dart View 1 3 chunks +40 lines, -1 line 0 comments Download
M pkg/analyzer/lib/src/summary/public_namespace_computer.dart View 1 2 chunks +14 lines, -1 line 0 comments Download
M pkg/analyzer/lib/src/summary/summarize_ast.dart View 1 chunk +1 line, -0 lines 0 comments Download
M pkg/analyzer/test/src/summary/summary_common.dart View 1 3 chunks +64 lines, -2 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
scheglov
4 years, 3 months ago (2016-09-15 16:46:19 UTC) #1
Paul Berry
https://codereview.chromium.org/2342893002/diff/1/pkg/analyzer/lib/src/summary/idl.dart File pkg/analyzer/lib/src/summary/idl.dart (right): https://codereview.chromium.org/2342893002/diff/1/pkg/analyzer/lib/src/summary/idl.dart#newcode1151 pkg/analyzer/lib/src/summary/idl.dart:1151: * an empty string if the condition does not ...
4 years, 3 months ago (2016-09-15 17:02:39 UTC) #2
scheglov
PTAL https://codereview.chromium.org/2342893002/diff/1/pkg/analyzer/lib/src/summary/idl.dart File pkg/analyzer/lib/src/summary/idl.dart (right): https://codereview.chromium.org/2342893002/diff/1/pkg/analyzer/lib/src/summary/idl.dart#newcode1151 pkg/analyzer/lib/src/summary/idl.dart:1151: * an empty string if the condition does ...
4 years, 3 months ago (2016-09-15 17:42:46 UTC) #3
Paul Berry
lgtm
4 years, 3 months ago (2016-09-15 18:44:03 UTC) #4
scheglov
4 years, 3 months ago (2016-09-15 19:00:36 UTC) #6
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
cfe56b9241f7ef1e8acecd64f05c4254a667cd02 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698