Clear stencil buffer before using it for drawing

Clear stencil buffer before using it for drawing

Clear stencil buffer before using it for drawing. This is
resolving an issue with a failing android CTS test in drawArc.
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2342873004

Committed: https://skia.googlesource.com/skia/+/c326a383e1069497884905f9dd3e720e17d8fcb5

[stani, 2016-09-16 13:30:04]

Description was changed from

==========
Clear stencil buffer before using it for drawing

Clear stencil buffer before using it for drawing. This is
resolving an issue with a failing android CTS test in drawArc.
==========

to

==========
Clear stencil buffer before using it for drawing

Clear stencil buffer before using it for drawing. This is
resolving an issue with a failing android CTS test in drawArc.
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2342873004
==========

[stani, 2016-09-16 13:38:37]

Description was changed from

==========
Clear stencil buffer before using it for drawing

Clear stencil buffer before using it for drawing. This is
resolving an issue with a failing android CTS test in drawArc.
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2342873004
==========

to

==========
Clear stencil buffer before using it for drawing

Clear stencil buffer before using it for drawing. This is
resolving an issue with a failing android CTS test in drawArc.
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2342873004
==========

[stani, 2016-09-16 13:38:38]

stani@google.com changed reviewers:
+ bsalomon@google.com, reed@google.com

[bsalomon, 2016-09-16 13:46:21]

lgtm

https://codereview.chromium.org/2342873004/diff/1/src/gpu/GrGpu.cpp
File src/gpu/GrGpu.cpp (right):

https://codereview.chromium.org/2342873004/diff/1/src/gpu/GrGpu.cpp#newcode227
src/gpu/GrGpu.cpp:227: if (desc.fStencilBits) {
Can we have a comment something to the effect of:

// Our algorithms that use the stencil buffer assume it is initially cleared.

[stani, 2016-09-16 17:06:33]

On 2016/09/16 13:46:21, bsalomon wrote:
> lgtm
> 
> https://codereview.chromium.org/2342873004/diff/1/src/gpu/GrGpu.cpp
> File src/gpu/GrGpu.cpp (right):
> 
> https://codereview.chromium.org/2342873004/diff/1/src/gpu/GrGpu.cpp#newcode227
> src/gpu/GrGpu.cpp:227: if (desc.fStencilBits) {
> Can we have a comment something to the effect of:
> 
> // Our algorithms that use the stencil buffer assume it is initially cleared.

done

[bsalomon, 2016-09-16 17:06:58]

lgtm

[stani, 2016-09-16 17:48:00]

The CQ bit was checked by stani@google.com

[commit-bot: I haz the power, 2016-09-16 17:48:07]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-16 18:03:45]

Description was changed from

==========
Clear stencil buffer before using it for drawing

Clear stencil buffer before using it for drawing. This is
resolving an issue with a failing android CTS test in drawArc.
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2342873004
==========

to

==========
Clear stencil buffer before using it for drawing

Clear stencil buffer before using it for drawing. This is
resolving an issue with a failing android CTS test in drawArc.
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2342873004

Committed:
https://skia.googlesource.com/skia/+/c326a383e1069497884905f9dd3e720e17d8fcb5
==========

[commit-bot: I haz the power, 2016-09-16 18:03:46]

Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/c326a383e1069497884905f9dd3e720e17d8fcb5

[stani, 2016-09-20 18:56:10]

A revert of this CL (patchset #2 id:20001) has been created in
https://codereview.chromium.org/2355923002/ by stani@google.com.

The reason for reverting is: performance regression in Android macrobench tests.