scripts/slave/recipe_modules/chromium_android/chromium_config.py - Issue 2342863002: Revert of Enable the ninja up-to-date check for Android builders

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: scripts/slave/recipe_modules/chromium_android/chromium_config.py

Issue 2342863002: Revert of Enable the ninja up-to-date check for Android builders (Closed)

Patch Set: Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « scripts/slave/recipe_modules/chromium/example.expected/basic_out_dir.json ('k') | scripts/slave/recipe_modules/chromium_android/example.expected/basic_builder_basic.json » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 # Copyright 2013 The Chromium Authors. All rights reserved.	1 # Copyright 2013 The Chromium Authors. All rights reserved.

2 # Use of this source code is governed by a BSD-style license that can be	2 # Use of this source code is governed by a BSD-style license that can be

3 # found in the LICENSE file.	3 # found in the LICENSE file.

4	4

5 from recipe_engine.config_types import Path	5 from recipe_engine.config_types import Path

6 from recipe_engine import config as recipe_config	6 from recipe_engine import config as recipe_config

7	7

8 import DEPS	8 import DEPS

9 CONFIG_CTX = DEPS['chromium'].CONFIG_CTX	9 CONFIG_CTX = DEPS['chromium'].CONFIG_CTX

10	10

11 @CONFIG_CTX(includes=['android_common', 'ninja', 'ninja_confirm_noop',	11 @CONFIG_CTX(includes=['android_common', 'ninja', 'static_library'],

12 'static_library'],

13 config_vars={'TARGET_ARCH': 'arm', 'TARGET_BITS': 32,	12 config_vars={'TARGET_ARCH': 'arm', 'TARGET_BITS': 32,

14 'TARGET_PLATFORM': 'android', 'BUILD_CONFIG': 'Debug'})	13 'TARGET_PLATFORM': 'android', 'BUILD_CONFIG': 'Debug'})

15 def base_config(c):	14 def base_config(c):

16 c.compile_py.default_targets=[]	15 c.compile_py.default_targets=[]

17	16

18 if c.HOST_PLATFORM != 'linux': # pragma: no cover	17 if c.HOST_PLATFORM != 'linux': # pragma: no cover

19 raise recipe_config.BadConf('Can only build android on linux.')	18 raise recipe_config.BadConf('Can only build android on linux.')

20	19

21 @CONFIG_CTX(includes=['base_config', 'default_compiler', 'goma'])	20 @CONFIG_CTX(includes=['base_config', 'default_compiler', 'goma'])

22 def main_builder(c):	21 def main_builder(c):

(...skipping 180 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
203 c.gyp_env.GYP_DEFINES['chromecast'] = 1	202 c.gyp_env.GYP_DEFINES['chromecast'] = 1

204	203

205 @CONFIG_CTX()	204 @CONFIG_CTX()

206 def disable_neon(c): # pragma: no cover	205 def disable_neon(c): # pragma: no cover

207 c.gn_args.append('arm_use_neon=false')	206 c.gn_args.append('arm_use_neon=false')

208 c.gyp_env.GYP_DEFINES['arm_neon'] = 0	207 c.gyp_env.GYP_DEFINES['arm_neon'] = 0

209	208

210 @CONFIG_CTX()	209 @CONFIG_CTX()

211 def errorprone(c):	210 def errorprone(c):

212 c.gyp_env.GYP_DEFINES['enable_errorprone'] = 1	211 c.gyp_env.GYP_DEFINES['enable_errorprone'] = 1

OLD	NEW