src/objects-printer.cc - Issue 2342853002: [TypeFeedbackVector] special ic slots for interpreter compare/binary ops.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/objects-printer.cc

Issue 2342853002: [TypeFeedbackVector] special ic slots for interpreter compare/binary ops. (Closed)

Patch Set: missing gyp support. Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/objects-printer.cc

diff --git a/src/objects-printer.cc b/src/objects-printer.cc

index 52bbcd5aca8d34bc0f9ab48635f93a4b901d22a9..77685ed0010dbcf8e7cb54c331a6d44d5183b9f6 100644

--- a/src/objects-printer.cc

+++ b/src/objects-printer.cc

@@ -750,6 +750,8 @@ void TypeFeedbackVector::TypeFeedbackVectorPrint(std::ostream& os) { // NOLINT

os << Code::ICState2String(nexus.StateFromFeedback());

break;

}

+ case FeedbackVectorSlotKind::INTERPRETER_BINARYOP_IC:

+ case FeedbackVectorSlotKind::INTERPRETER_COMPARE_IC:

mythria 2016/09/20 12:35:16 Would it be helpful to print the binary/compare op

mvstanton 2016/09/20 13:19:22 Absolutely, will do!

case FeedbackVectorSlotKind::GENERAL:

break;

case FeedbackVectorSlotKind::INVALID:

« no previous file with comments | « src/compiler/type-hints.cc ('k') | src/runtime-profiler.cc » ('j') | no next file with comments »