Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(213)

Issue 2342783004: views: use MD padding for combobox (Closed)

Created:
4 years, 3 months ago by Elly Fong-Jones
Modified:
4 years, 3 months ago
Reviewers:
sky
CC:
chromium-reviews, tfarina
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

views: use MD padding for combobox This change was originally part of https://codereview.chromium.org/2317033002, but fell on the floor. Oops! BUG=644709 Committed: https://crrev.com/7e41d4becf20af46ef3c392a199f16fa9c987ddf Cr-Commit-Position: refs/heads/master@{#419243}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -1 line) Patch
M ui/views/controls/combobox/combobox.cc View 1 chunk +4 lines, -1 line 0 comments Download

Messages

Total messages: 10 (5 generated)
Elly Fong-Jones
sky: ptal as views owner? :)
4 years, 3 months ago (2016-09-16 13:05:07 UTC) #3
sky
LGTM
4 years, 3 months ago (2016-09-16 17:22:08 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2342783004/1
4 years, 3 months ago (2016-09-16 18:21:07 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-09-16 19:19:00 UTC) #8
commit-bot: I haz the power
4 years, 3 months ago (2016-09-16 19:20:52 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/7e41d4becf20af46ef3c392a199f16fa9c987ddf
Cr-Commit-Position: refs/heads/master@{#419243}

Powered by Google App Engine
This is Rietveld 408576698