Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(211)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2342733002: Break up another large file (Closed)

Created:
4 years, 3 months ago by Brian Wilkerson
Modified:
4 years, 3 months ago
Reviewers:
scheglov
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : fixed floating comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1667 lines, -7724 lines) Patch
M pkg/analysis_server/lib/plugin/edit/fix/fix_core.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analysis_server/lib/src/edit/edit_domain.dart View 1 chunk +2 lines, -1 line 0 comments Download
M pkg/analysis_server/lib/src/operation/operation_analysis.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analysis_server/lib/src/protocol_server.dart View 1 chunk +2 lines, -1 line 0 comments Download
M pkg/analysis_server/lib/src/services/correction/fix.dart View 1 chunk +2 lines, -1 line 0 comments Download
M pkg/analysis_server/lib/src/services/correction/fix_internal.dart View 1 chunk +2 lines, -1 line 0 comments Download
M pkg/analysis_server/lib/src/services/correction/organize_directives.dart View 1 chunk +2 lines, -1 line 0 comments Download
M pkg/analysis_server/lib/src/services/correction/source_range.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analysis_server/lib/src/status/get_handler.dart View 2 chunks +1 line, -1 line 0 comments Download
M pkg/analysis_server/lib/src/status/validator.dart View 4 chunks +4 lines, -1 line 0 comments Download
M pkg/analysis_server/test/abstract_single_unit.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analysis_server/test/context_manager_test.dart View 1 chunk +4 lines, -1 line 0 comments Download
M pkg/analysis_server/test/plugin/protocol_dart_test.dart View 1 chunk +2 lines, -1 line 0 comments Download
M pkg/analysis_server/test/protocol_server_test.dart View 1 chunk +2 lines, -1 line 0 comments Download
M pkg/analysis_server/test/services/completion/dart/local_declaration_visitor_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analysis_server/test/services/correction/fix_test.dart View 1 chunk +2 lines, -1 line 0 comments Download
M pkg/analysis_server/test/services/correction/organize_directives_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analysis_server/test/services/correction/source_range_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analysis_server/test/stress/replay/replay.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analyzer/example/parser_driver.dart View 1 chunk +2 lines, -1 line 0 comments Download
M pkg/analyzer/lib/analyzer.dart View 1 chunk +7 lines, -4 lines 0 comments Download
A pkg/analyzer/lib/error/error.dart View 1 chunk +1067 lines, -0 lines 0 comments Download
A pkg/analyzer/lib/error/listener.dart View 1 chunk +322 lines, -0 lines 0 comments Download
M pkg/analyzer/lib/plugin/options.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analyzer/lib/source/error_processor.dart View 1 chunk +4 lines, -1 line 0 comments Download
M pkg/analyzer/lib/src/context/context.dart View 2 chunks +1 line, -1 line 0 comments Download
M pkg/analyzer/lib/src/dart/constant/evaluation.dart View 1 chunk +3 lines, -1 line 0 comments Download
M pkg/analyzer/lib/src/dart/constant/value.dart View 1 chunk +2 lines, -1 line 0 comments Download
M pkg/analyzer/lib/src/dart/element/builder.dart View 1 chunk +2 lines, -1 line 0 comments Download
M pkg/analyzer/lib/src/dart/element/element.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analyzer/lib/src/dart/resolver/inheritance_manager.dart View 1 chunk +2 lines, -1 line 0 comments Download
M pkg/analyzer/lib/src/dart/resolver/scope.dart View 1 chunk +2 lines, -1 line 0 comments Download
M pkg/analyzer/lib/src/dart/scanner/scanner.dart View 3 chunks +6 lines, -3 lines 0 comments Download
M pkg/analyzer/lib/src/dart/sdk/sdk.dart View 2 chunks +1 line, -1 line 0 comments Download
M pkg/analyzer/lib/src/error.dart View 1 chunk +1 line, -1 line 0 comments Download
A + pkg/analyzer/lib/src/error/codes.dart View 4 chunks +2 lines, -1328 lines 0 comments Download
M pkg/analyzer/lib/src/error/pending_error.dart View 1 chunk +2 lines, -1 line 0 comments Download
M pkg/analyzer/lib/src/generated/constant.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analyzer/lib/src/generated/element_resolver.dart View 2 chunks +2 lines, -1 line 0 comments Download
M pkg/analyzer/lib/src/generated/engine.dart View 4 chunks +3 lines, -61 lines 0 comments Download
M pkg/analyzer/lib/src/generated/error.dart View 1 chunk +6 lines, -6143 lines 0 comments Download
M pkg/analyzer/lib/src/generated/error_verifier.dart View 1 chunk +3 lines, -1 line 0 comments Download
M pkg/analyzer/lib/src/generated/incremental_resolver.dart View 2 chunks +2 lines, -1 line 0 comments Download
M pkg/analyzer/lib/src/generated/parser.dart View 1 chunk +3 lines, -1 line 0 comments Download
M pkg/analyzer/lib/src/generated/resolver.dart View 2 chunks +3 lines, -1 line 0 comments Download
M pkg/analyzer/lib/src/generated/type_system.dart View 3 chunks +17 lines, -17 lines 0 comments Download
M pkg/analyzer/lib/src/plugin/engine_plugin.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analyzer/lib/src/services/lint.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analyzer/lib/src/summary/incremental_cache.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analyzer/lib/src/summary/pub_summary.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analyzer/lib/src/task/dart.dart View 2 chunks +3 lines, -1 line 0 comments Download
M pkg/analyzer/lib/src/task/dart_work_manager.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analyzer/lib/src/task/html.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analyzer/lib/src/task/html_work_manager.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analyzer/lib/src/task/options.dart View 1 chunk +8 lines, -0 lines 0 comments Download
M pkg/analyzer/lib/src/task/options_work_manager.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analyzer/lib/src/task/strong/checker.dart View 1 9 chunks +42 lines, -41 lines 0 comments Download
M pkg/analyzer/lib/src/task/yaml.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analyzer/lib/task/dart.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analyzer/lib/task/html.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analyzer/lib/task/model.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analyzer/lib/task/yaml.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analyzer/test/enum_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analyzer/test/generated/all_the_rest_test.dart View 2 chunks +3 lines, -1 line 0 comments Download
M pkg/analyzer/test/generated/checked_mode_compile_time_error_code_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analyzer/test/generated/compile_time_error_code_test.dart View 1 chunk +2 lines, -1 line 0 comments Download
M pkg/analyzer/test/generated/engine_test.dart View 2 chunks +1 line, -1 line 0 comments Download
M pkg/analyzer/test/generated/error_suppression_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analyzer/test/generated/hint_code_test.dart View 3 chunks +11 lines, -10 lines 0 comments Download
M pkg/analyzer/test/generated/incremental_resolver_test.dart View 2 chunks +2 lines, -1 line 0 comments Download
M pkg/analyzer/test/generated/inheritance_manager_test.dart View 1 chunk +2 lines, -1 line 0 comments Download
M pkg/analyzer/test/generated/non_error_resolver_test.dart View 1 chunk +2 lines, -1 line 0 comments Download
M pkg/analyzer/test/generated/non_hint_code_test.dart View 1 chunk +2 lines, -1 line 0 comments Download
M pkg/analyzer/test/generated/parser_test.dart View 1 chunk +2 lines, -1 line 0 comments Download
M pkg/analyzer/test/generated/resolver_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analyzer/test/generated/resolver_test_case.dart View 1 chunk +2 lines, -1 line 0 comments Download
M pkg/analyzer/test/generated/scanner_test.dart View 1 chunk +2 lines, -1 line 0 comments Download
M pkg/analyzer/test/generated/simple_resolver_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analyzer/test/generated/static_type_warning_code_test.dart View 1 chunk +2 lines, -1 line 0 comments Download
M pkg/analyzer/test/generated/static_warning_code_test.dart View 1 chunk +2 lines, -1 line 0 comments Download
M pkg/analyzer/test/generated/strong_mode_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analyzer/test/generated/test_support.dart View 1 chunk +2 lines, -1 line 0 comments Download
M pkg/analyzer/test/source/error_processor_test.dart View 1 chunk +2 lines, -1 line 0 comments Download
M pkg/analyzer/test/src/abstract_single_unit.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analyzer/test/src/context/context_test.dart View 2 chunks +1 line, -1 line 0 comments Download
M pkg/analyzer/test/src/dart/constant/evaluation_test.dart View 1 chunk +3 lines, -1 line 0 comments Download
M pkg/analyzer/test/src/summary/incremental_cache_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analyzer/test/src/summary/resynthesize_test.dart View 1 chunk +2 lines, -1 line 0 comments Download
M pkg/analyzer/test/src/summary/summarize_ast_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analyzer/test/src/summary/summary_common.dart View 3 chunks +30 lines, -30 lines 0 comments Download
M pkg/analyzer/test/src/task/dart_test.dart View 1 chunk +2 lines, -1 line 0 comments Download
M pkg/analyzer/test/src/task/dart_work_manager_test.dart View 2 chunks +1 line, -1 line 0 comments Download
M pkg/analyzer/test/src/task/html_work_manager_test.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M pkg/analyzer/test/src/task/options_test.dart View 1 chunk +2 lines, -0 lines 0 comments Download
M pkg/analyzer/test/src/task/options_work_manager_test.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M pkg/analyzer/test/src/task/strong/strong_test_helper.dart View 2 chunks +4 lines, -1 line 0 comments Download
M pkg/analyzer/test/stress/for_git_repository.dart View 2 chunks +1 line, -1 line 0 comments Download
M pkg/analyzer/tool/summary/generate.dart View 1 chunk +1 line, -0 lines 0 comments Download
M pkg/dev_compiler/lib/src/compiler/side_effect_analysis.dart View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5 (2 generated)
Brian Wilkerson
There are no changes other than the code that was moved to new libraries, and ...
4 years, 3 months ago (2016-09-15 00:33:00 UTC) #2
scheglov
LGTM
4 years, 3 months ago (2016-09-15 03:07:35 UTC) #3
Brian Wilkerson
4 years, 3 months ago (2016-09-15 14:49:39 UTC) #5
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) manually as
ecc84b26a4ea4a4b83986d27097d7260d24e9d2d (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698