Reland: Update image and text color when row is selected in the chooser on Mac

chrome/browser/ui/views/chooser_content_view.cc

Index: chrome/browser/ui/views/chooser_content_view.cc
diff --git a/chrome/browser/ui/views/chooser_content_view.cc b/chrome/browser/ui/views/chooser_content_view.cc
index c4b1ab03922943b32c8225ff36334fe5e45e1a0e..085f3343d6380a0473e4baa0b833e338e9958a4d 100644
--- a/chrome/browser/ui/views/chooser_content_view.cc
+++ b/chrome/browser/ui/views/chooser_content_view.cc
@@ -28,9 +28,9 @@ const int kChooserHeight = 220;
 const int kThrobberDiameter = 24;
 
 // The lookup table for signal strength level image.
-const int kSignalStrengthLevelImageIds[5] = {IDR_SIGNAL_0_BAR, IDR_SIGNAL_1_BAR,
-                                             IDR_SIGNAL_2_BAR, IDR_SIGNAL_3_BAR,
-                                             IDR_SIGNAL_4_BAR};
+const int kSignalStrengthLevelBlackImageIds[5] = {

[sky, 2016/09/21 17:41:19]

Is there a reason views doesn't change color like mac?

Also, did you consider leaving the ones you named as black as they were before
and instead of white using selected? So, you would have IDR_SIGNAL_0_BAR and
IDR_SIGNAL_0_BAR_SELECTED. It seems clearer that way as the names black and
white don't convey their expected usage.

[juncai, 2016/09/21 19:51:24]

The row in the chooser on Mac is a NSView:
https://cs.chromium.org/chromium/src/chrome/browser/ui/cocoa/website_settings...
And it doesn't automatically change its color when selected.
Done.

+    IDR_SIGNAL_0_BAR_BLACK, IDR_SIGNAL_1_BAR_BLACK, IDR_SIGNAL_2_BAR_BLACK,
+    IDR_SIGNAL_3_BAR_BLACK, IDR_SIGNAL_4_BAR_BLACK};
 
 }  // namespace
 
@@ -124,10 +124,11 @@ gfx::ImageSkia ChooserContentView::GetIcon(int row) {
     return gfx::ImageSkia();
 
   DCHECK_GE(level, 0);
-  DCHECK_LT(level, static_cast<int>(arraysize(kSignalStrengthLevelImageIds)));
+  DCHECK_LT(level,
+            static_cast<int>(arraysize(kSignalStrengthLevelBlackImageIds)));
 
   return *ResourceBundle::GetSharedInstance().GetImageSkiaNamed(
-      kSignalStrengthLevelImageIds[level]);
+      kSignalStrengthLevelBlackImageIds[level]);
 }
 
 void ChooserContentView::OnOptionsInitialized() {