|
|
DescriptionSet crash key if WM_QUIT message is received on GPU message loop.
Threads seem to be exiting unexpectedly, so to help debugging set a
crash key if an unexpected WM_QUIT message is received.
BUG=647068
TBR=scottmg@chromium.org
Committed: https://crrev.com/18db6b0cc6f81fba74278cfab2856ccb11c0e0c7
Cr-Commit-Position: refs/heads/master@{#419057}
Patch Set 1 #Patch Set 2 : add comment #Patch Set 3 : add correct registration #
Messages
Total messages: 34 (20 generated)
The CQ bit was checked by jbauman@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was checked by jbauman@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
jbauman@chromium.org changed reviewers: + dcheng@chromium.org
lgtm
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by jbauman@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Committed patchset #2 (id:20001)
Message was sent while issue was closed.
Description was changed from ========== Set crash key if WM_QUIT message is received on GPU message loop. Threads seem to be exiting unexpectedly, so to help debugging set a crash key if an unexpected WM_QUIT message is received. BUG=647068 ========== to ========== Set crash key if WM_QUIT message is received on GPU message loop. Threads seem to be exiting unexpectedly, so to help debugging set a crash key if an unexpected WM_QUIT message is received. BUG=647068 Committed: https://crrev.com/fafd9b39256b14f96283e5155d05e7f8f805689c Cr-Commit-Position: refs/heads/master@{#418753} ==========
Message was sent while issue was closed.
Patchset 2 (id:??) landed as https://crrev.com/fafd9b39256b14f96283e5155d05e7f8f805689c Cr-Commit-Position: refs/heads/master@{#418753}
Message was sent while issue was closed.
A revert of this CL (patchset #2 id:20001) has been created in https://codereview.chromium.org/2339123003/ by jbauman@chromium.org. The reason for reverting is: Forgot key registration..
Message was sent while issue was closed.
Description was changed from ========== Set crash key if WM_QUIT message is received on GPU message loop. Threads seem to be exiting unexpectedly, so to help debugging set a crash key if an unexpected WM_QUIT message is received. BUG=647068 Committed: https://crrev.com/fafd9b39256b14f96283e5155d05e7f8f805689c Cr-Commit-Position: refs/heads/master@{#418753} ========== to ========== Set crash key if WM_QUIT message is received on GPU message loop. Threads seem to be exiting unexpectedly, so to help debugging set a crash key if an unexpected WM_QUIT message is received. BUG=647068 Committed: https://crrev.com/fafd9b39256b14f96283e5155d05e7f8f805689c Cr-Commit-Position: refs/heads/master@{#418753} ==========
The CQ bit was checked by jbauman@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
jbauman@chromium.org changed reviewers: + rsesek@chromium.org, scottmg@chromium.org
scottmg@ and rsesek@: crash key registration OWNERS review.
lgtm
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
(Is there a presubmit this catches this, or does a bot actually break?)
On 2016/09/15 22:02:02, dcheng wrote: > (Is there a presubmit this catches this, or does a bot actually break?) No bot broke, but I discovered it would have hit a DCHECK if this code is actually hit, so I figured might as well revert.
Description was changed from ========== Set crash key if WM_QUIT message is received on GPU message loop. Threads seem to be exiting unexpectedly, so to help debugging set a crash key if an unexpected WM_QUIT message is received. BUG=647068 Committed: https://crrev.com/fafd9b39256b14f96283e5155d05e7f8f805689c Cr-Commit-Position: refs/heads/master@{#418753} ========== to ========== Set crash key if WM_QUIT message is received on GPU message loop. Threads seem to be exiting unexpectedly, so to help debugging set a crash key if an unexpected WM_QUIT message is received. BUG=647068 TBR=scottmg@chromium.org ==========
The CQ bit was checked by jbauman@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from dcheng@chromium.org Link to the patchset: https://codereview.chromium.org/2342713002/#ps40001 (title: "add correct registration")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Description was changed from ========== Set crash key if WM_QUIT message is received on GPU message loop. Threads seem to be exiting unexpectedly, so to help debugging set a crash key if an unexpected WM_QUIT message is received. BUG=647068 TBR=scottmg@chromium.org ========== to ========== Set crash key if WM_QUIT message is received on GPU message loop. Threads seem to be exiting unexpectedly, so to help debugging set a crash key if an unexpected WM_QUIT message is received. BUG=647068 TBR=scottmg@chromium.org ==========
Message was sent while issue was closed.
Committed patchset #3 (id:40001)
Message was sent while issue was closed.
Description was changed from ========== Set crash key if WM_QUIT message is received on GPU message loop. Threads seem to be exiting unexpectedly, so to help debugging set a crash key if an unexpected WM_QUIT message is received. BUG=647068 TBR=scottmg@chromium.org ========== to ========== Set crash key if WM_QUIT message is received on GPU message loop. Threads seem to be exiting unexpectedly, so to help debugging set a crash key if an unexpected WM_QUIT message is received. BUG=647068 TBR=scottmg@chromium.org Committed: https://crrev.com/18db6b0cc6f81fba74278cfab2856ccb11c0e0c7 Cr-Commit-Position: refs/heads/master@{#419057} ==========
Message was sent while issue was closed.
Patchset 3 (id:??) landed as https://crrev.com/18db6b0cc6f81fba74278cfab2856ccb11c0e0c7 Cr-Commit-Position: refs/heads/master@{#419057}
Message was sent while issue was closed.
A revert of this CL (patchset #3 id:40001) has been created in https://codereview.chromium.org/2346353002/ by jbauman@chromium.org. The reason for reverting is: We've got enough data now.. |