Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(113)

Issue 2342713002: Set crash key if WM_QUIT message is received on GPU message loop. (Closed)

Created:
4 years, 3 months ago by jbauman
Modified:
4 years, 3 months ago
CC:
chromium-reviews, sadrul
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Set crash key if WM_QUIT message is received on GPU message loop. Threads seem to be exiting unexpectedly, so to help debugging set a crash key if an unexpected WM_QUIT message is received. BUG=647068 TBR=scottmg@chromium.org Committed: https://crrev.com/18db6b0cc6f81fba74278cfab2856ccb11c0e0c7 Cr-Commit-Position: refs/heads/master@{#419057}

Patch Set 1 #

Patch Set 2 : add comment #

Patch Set 3 : add correct registration #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -0 lines) Patch
M base/message_loop/message_pump_win.cc View 1 2 chunks +6 lines, -0 lines 0 comments Download
M blimp/engine/app/blimp_engine_crash_keys.cc View 1 2 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/app/chrome_crash_reporter_client_win.cc View 1 2 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/common/crash_keys.cc View 1 2 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 34 (20 generated)
jbauman
4 years, 3 months ago (2016-09-15 00:47:08 UTC) #6
dcheng
lgtm
4 years, 3 months ago (2016-09-15 00:55:01 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2342713002/20001
4 years, 3 months ago (2016-09-15 01:54:24 UTC) #11
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 3 months ago (2016-09-15 01:59:58 UTC) #12
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/fafd9b39256b14f96283e5155d05e7f8f805689c Cr-Commit-Position: refs/heads/master@{#418753}
4 years, 3 months ago (2016-09-15 02:04:54 UTC) #14
jbauman
A revert of this CL (patchset #2 id:20001) has been created in https://codereview.chromium.org/2339123003/ by jbauman@chromium.org. ...
4 years, 3 months ago (2016-09-15 05:32:18 UTC) #15
jbauman
scottmg@ and rsesek@: crash key registration OWNERS review.
4 years, 3 months ago (2016-09-15 20:13:11 UTC) #20
Robert Sesek
lgtm
4 years, 3 months ago (2016-09-15 20:15:44 UTC) #21
dcheng
(Is there a presubmit this catches this, or does a bot actually break?)
4 years, 3 months ago (2016-09-15 22:02:02 UTC) #24
jbauman
On 2016/09/15 22:02:02, dcheng wrote: > (Is there a presubmit this catches this, or does ...
4 years, 3 months ago (2016-09-15 22:08:49 UTC) #25
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2342713002/40001
4 years, 3 months ago (2016-09-16 00:29:11 UTC) #29
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 3 months ago (2016-09-16 00:36:10 UTC) #31
commit-bot: I haz the power
Patchset 3 (id:??) landed as https://crrev.com/18db6b0cc6f81fba74278cfab2856ccb11c0e0c7 Cr-Commit-Position: refs/heads/master@{#419057}
4 years, 3 months ago (2016-09-16 00:40:03 UTC) #33
jbauman
4 years, 3 months ago (2016-09-19 18:58:21 UTC) #34
Message was sent while issue was closed.
A revert of this CL (patchset #3 id:40001) has been created in
https://codereview.chromium.org/2346353002/ by jbauman@chromium.org.

The reason for reverting is: We've got enough data now..

Powered by Google App Engine
This is Rietveld 408576698