Issue 2342703002: Merged: Properly handle holes following spreads in array literals

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2342703002: Merged: Properly handle holes following spreads in array literals (Closed)

Created:
4 years, 3 months ago by adamk

Modified:
4 years, 3 months ago

Reviewers:
Michael Hablich

CC:
v8-reviews_googlegroups.com, v8-merges_googlegroups.com

Target Ref:
refs/pending/branch-heads/5.4

Project:
v8

Visibility:
Public.

More Reviews

Description

Merged: Properly handle holes following spreads in array literals Revision: e4273007b613950845e92d479485ec737eb61185 NOTRY=true NOPRESUBMIT=true NOTREECHECKS=true BUG=chromium:644215 TBR=hablich@chromium.org

Patch Set 1 #

Created: 4 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+42 lines, -9 lines)			Patch
M	src/ast/ast-value-factory.h	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	src/parsing/parser.cc	View	1 chunk	+27 lines, -9 lines	0 comments	Download
M	src/runtime/runtime-object.cc	View	1 chunk	+1 line, -0 lines	0 comments	Download
A	test/mjsunit/regress/regress-crbug-644215.js	View	1 chunk	+13 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2342703002/1

4 years, 3 months ago (2016-09-14 23:05:29 UTC) #2

Message was sent while issue was closed.

Committed patchset #1 (id:1)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages