Add files missing from gn and fix verify script

tools/verify_source_deps.py

Index: tools/verify_source_deps.py
diff --git a/tools/verify_source_deps.py b/tools/verify_source_deps.py
index 56e3156550aa4c07bac6e87445a0d82f472366c5..4cfedc40fcfcba2c91b7d5f358e0735113d26ca3 100755
--- a/tools/verify_source_deps.py
+++ b/tools/verify_source_deps.py
@@ -25,16 +25,40 @@ V8_INCLUDE_BASE = os.path.join(V8_BASE, 'include')
 GYP_FILES = [
   os.path.join(V8_BASE, 'src', 'd8.gyp'),
   os.path.join(V8_BASE, 'src', 'v8.gyp'),
+  os.path.join(V8_BASE, 'src', 'inspector', 'inspector.gyp'),
   os.path.join(V8_BASE, 'src', 'third_party', 'vtune', 'v8vtune.gyp'),
   os.path.join(V8_BASE, 'test', 'cctest', 'cctest.gyp'),
   os.path.join(V8_BASE, 'test', 'unittests', 'unittests.gyp'),
   os.path.join(V8_BASE, 'tools', 'parser-shell.gyp'),
 ]
 
+GN_FILES = [
+  os.path.join(V8_BASE, 'BUILD.gn'),
+  os.path.join(V8_BASE, 'src', 'inspector', 'BUILD.gn'),
+  os.path.join(V8_BASE, 'test', 'cctest', 'BUILD.gn'),
+  os.path.join(V8_BASE, 'test', 'unittests', 'BUILD.gn'),
+  os.path.join(V8_BASE, 'tools', 'BUILD.gn'),
+]
+
+GN_UNSUPPORTED_FEATURES = [
+  'aix',
+  'cygwin',
+  'freebsd',
+  'openbsd',
+  'ppc',
+  'qnx',
+  'solaris',
+  'valgrind',
+  'vtune',
+  'x87',
+]
+
 
 def path_no_prefix(path):

[vogelheim, 2016/09/15 12:07:06]

maybe:

for prefix in ['..', 'src/inspector/', ...]:
  if path.startswith(prefix):
    return path_no_pref_prefix(path[len(prefix):])

(This would make sense if you expect more prefixes to be handled in the future.)

[jochen (gone - plz use gerrit), 2016/09/15 12:24:18]

done

   if path.startswith('../'):
     return path_no_prefix(path[3:])
+  elif path.startswith('src/inspector/'):
+    return path_no_prefix(path[14:])
   elif path.startswith('src/'):
     return path_no_prefix(path[4:])
   else:
@@ -99,8 +123,12 @@ print "----------- Files not in gyp: ------------"
 for i in sorted(icheck_values(gyp_values, V8_SRC_BASE, V8_INCLUDE_BASE)):
   print i
 
-gn_values = set(iflatten_gn_file(os.path.join(V8_BASE, 'BUILD.gn')))
+gn_values = set(itertools.chain(
+  *[iflatten_gn_file(gn_file) for gn_file in GN_FILES]
+  ))
 
 print "\n----------- Files not in gn: -------------"
 for i in sorted(icheck_values(gn_values, V8_SRC_BASE, V8_INCLUDE_BASE)):
+  if set((f for f in GN_UNSUPPORTED_FEATURES if f in i)):

[vogelheim, 2016/09/15 12:07:05]

If I understand this, you want to know whether there is any element that's in
both GN_UNSUPPORTED_FEATURES or i.

Option 1: any( (f in GN_UNSUPPORTED_FEATURES for f in i) )

Option 2: have, somewhere, a set(GN_UNSUPPORTED_FEATURES), then:
if not GN_UNSUPPORTED_FEATURE_SET.intersection(i):

[vogelheim, 2016/09/15 12:07:05]

Why set(..)?

I know the set(...) trick mainly to de-duplicate values in the list. But if you
use it as boolean condition, you're really checking for emptiness. But empty
list == empty set, so that doesn't do anything, does it?

[jochen (gone - plz use gerrit), 2016/09/15 12:24:18]

i is a filename, like 'disassembler-ppc.cc', and unsupported features would
contain the string 'ppc'.

Without the set() I'm getting an generator which always goes to true. set()
force-materializes the result.

[vogelheim, 2016/09/15 12:39:54]

Ahh... I don't think 'force-materialize' exists in Python. You're using set to
test for the emptiness of the generator. That's still awkward.

Maybe:
for i in ....:
  if [f for f in GN_UNSUPPORTED_FEATURES in f in i]:
    continue

That way, you stuff it all in a list, and an empty list is false.

Or, maybe:

for i in ....:
  if any(f in i for f in GN_UNSUPPORTED_FEATURES):
    continue


Or, really:

for i in ....:
  if not any(feature in i for feature in GN_UNSUPPORTED_FEATURES):
    print i

+    continue
   print i