Add files missing from gn and fix verify script

Add files missing from gn and fix verify script

R=machenbach@chromium.org
BUG=

Committed: https://crrev.com/0e938d4ac0f7d9bbb071cfac5cedcdfef9bbfb14
Cr-Commit-Position: refs/heads/master@{#39447}

[jochen (gone - plz use gerrit), 2016-09-15 08:07:52]

The CQ bit was checked by jochen@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-15 08:08:01]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[jochen (gone - plz use gerrit), 2016-09-15 08:08:29]

~/v8$ tools/verify_source_deps.py 
----------- Files not in gyp: ------------
Allocator.h
Atomics.h
InjectedScript.h
InjectedScriptNative.h
InspectedContext.h
JavaScriptCallFrame.h
ProtocolPlatform.h
RemoteObjectId.h
ScriptBreakpoint.h
SearchUtil.h
String16.h
StringUtil.h
V8Console.h
V8ConsoleAgentImpl.h
V8ConsoleMessage.h
V8Debugger.h
V8DebuggerAgentImpl.h
V8DebuggerScript.h
V8FunctionCall.h
V8HeapProfilerAgentImpl.h
V8InjectedScriptHost.h
V8InspectorImpl.h
V8InspectorSessionImpl.h
V8InternalValueType.h
V8ProfilerAgentImpl.h
V8Regex.h
V8RuntimeAgentImpl.h
V8SchemaAgentImpl.h
V8StackTraceImpl.h
V8ValueCopier.h
ia32/simulator-ia32.cc
ia32/simulator-ia32.h
ic/handler-configuration.h
include/v8-inspector-protocol.h
include/v8-inspector.h
third_party/valgrind/valgrind.h
third_party/vtune/ittnotify_config.h
third_party/vtune/ittnotify_types.h
third_party/vtune/jitprofiling.cc
third_party/vtune/jitprofiling.h
third_party/vtune/v8-vtune.h
third_party/vtune/vtune-jit.cc
third_party/vtune/vtune-jit.h
x64/simulator-x64.cc
x64/simulator-x64.h
x87/simulator-x87.cc
x87/simulator-x87.h

----------- Files not in gn: -------------

~/v8$

[commit-bot: I haz the power, 2016-09-15 08:09:50]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-15 08:09:51]

Dry run: Try jobs failed on following builders:
  v8_android_arm_compile_rel on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_android_arm_compile_rel/...)
  v8_linux64_avx2_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_avx2_rel_ng/buil...)
  v8_linux_dbg_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_dbg_ng/builds/12784)
  v8_linux_mipsel_compile_rel on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_mipsel_compile_rel...)

[jochen (gone - plz use gerrit), 2016-09-15 09:02:33]

The CQ bit was checked by jochen@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-15 09:02:36]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[jochen (gone - plz use gerrit), 2016-09-15 09:22:38]

jochen@chromium.org changed reviewers:
+ vogelheim@chromium.org

[jochen (gone - plz use gerrit), 2016-09-15 09:22:38]

+vogelheim

[commit-bot: I haz the power, 2016-09-15 09:28:29]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-15 09:28:30]

Dry run: This issue passed the CQ dry run.

[vogelheim, 2016-09-15 12:07:06]

lgtm, except I'm not sure about the simulator thing. Otherwise, just nitpicks.

https://codereview.chromium.org/2342663004/diff/20001/BUILD.gn
File BUILD.gn (right):

https://codereview.chromium.org/2342663004/diff/20001/BUILD.gn#newcode1742
BUILD.gn:1742: "src/ia32/simulator-ia32.h",
Do we really want to have the simulators in v8_base ?

https://codereview.chromium.org/2342663004/diff/20001/tools/verify_source_dep...
File tools/verify_source_deps.py (right):

https://codereview.chromium.org/2342663004/diff/20001/tools/verify_source_dep...
tools/verify_source_deps.py:57: def path_no_prefix(path):
maybe:

for prefix in ['..', 'src/inspector/', ...]:
  if path.startswith(prefix):
    return path_no_pref_prefix(path[len(prefix):])

(This would make sense if you expect more prefixes to be handled in the future.)

https://codereview.chromium.org/2342663004/diff/20001/tools/verify_source_dep...
tools/verify_source_deps.py:132: if set((f for f in GN_UNSUPPORTED_FEATURES if f
in i)):
Why set(..)?

I know the set(...) trick mainly to de-duplicate values in the list. But if you
use it as boolean condition, you're really checking for emptiness. But empty
list == empty set, so that doesn't do anything, does it?

https://codereview.chromium.org/2342663004/diff/20001/tools/verify_source_dep...
tools/verify_source_deps.py:132: if set((f for f in GN_UNSUPPORTED_FEATURES if f
in i)):
If I understand this, you want to know whether there is any element that's in
both GN_UNSUPPORTED_FEATURES or i.

Option 1: any( (f in GN_UNSUPPORTED_FEATURES for f in i) )

Option 2: have, somewhere, a set(GN_UNSUPPORTED_FEATURES), then:
if not GN_UNSUPPORTED_FEATURE_SET.intersection(i):

[jochen (gone - plz use gerrit), 2016-09-15 12:24:18]

https://codereview.chromium.org/2342663004/diff/20001/BUILD.gn
File BUILD.gn (right):

https://codereview.chromium.org/2342663004/diff/20001/BUILD.gn#newcode1742
BUILD.gn:1742: "src/ia32/simulator-ia32.h",
On 2016/09/15 at 12:07:05, vogelheim wrote:
> Do we really want to have the simulators in v8_base ?

where else would we put them? note that v8_base != v8_libbase...

https://codereview.chromium.org/2342663004/diff/20001/tools/verify_source_dep...
File tools/verify_source_deps.py (right):

https://codereview.chromium.org/2342663004/diff/20001/tools/verify_source_dep...
tools/verify_source_deps.py:57: def path_no_prefix(path):
On 2016/09/15 at 12:07:06, vogelheim wrote:
> maybe:
> 
> for prefix in ['..', 'src/inspector/', ...]:
>   if path.startswith(prefix):
>     return path_no_pref_prefix(path[len(prefix):])
> 
> (This would make sense if you expect more prefixes to be handled in the
future.)

done

https://codereview.chromium.org/2342663004/diff/20001/tools/verify_source_dep...
tools/verify_source_deps.py:132: if set((f for f in GN_UNSUPPORTED_FEATURES if f
in i)):
i is a filename, like 'disassembler-ppc.cc', and unsupported features would
contain the string 'ppc'.

Without the set() I'm getting an generator which always goes to true. set()
force-materializes the result.

[jochen (gone - plz use gerrit), 2016-09-15 12:24:18]

The CQ bit was checked by jochen@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-15 12:24:25]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[vogelheim, 2016-09-15 12:39:54]

https://codereview.chromium.org/2342663004/diff/20001/tools/verify_source_dep...
File tools/verify_source_deps.py (right):

https://codereview.chromium.org/2342663004/diff/20001/tools/verify_source_dep...
tools/verify_source_deps.py:132: if set((f for f in GN_UNSUPPORTED_FEATURES if f
in i)):
On 2016/09/15 12:24:18, jochen wrote:
> i is a filename, like 'disassembler-ppc.cc', and unsupported features would
> contain the string 'ppc'.
> 
> Without the set() I'm getting an generator which always goes to true. set()
> force-materializes the result.

Ahh... I don't think 'force-materialize' exists in Python. You're using set to
test for the emptiness of the generator. That's still awkward.

Maybe:
for i in ....:
  if [f for f in GN_UNSUPPORTED_FEATURES in f in i]:
    continue

That way, you stuff it all in a list, and an empty list is false.

Or, maybe:

for i in ....:
  if any(f in i for f in GN_UNSUPPORTED_FEATURES):
    continue


Or, really:

for i in ....:
  if not any(feature in i for feature in GN_UNSUPPORTED_FEATURES):
    print i

[jochen (gone - plz use gerrit), 2016-09-15 12:49:59]

The CQ bit was checked by jochen@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-15 12:50:03]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[jochen (gone - plz use gerrit), 2016-09-15 12:50:12]

done

[jochen (gone - plz use gerrit), 2016-09-15 12:55:22]

The CQ bit was unchecked by jochen@chromium.org

[jochen (gone - plz use gerrit), 2016-09-15 12:55:26]

The CQ bit was checked by jochen@chromium.org

[jochen (gone - plz use gerrit), 2016-09-15 12:55:26]

The patchset sent to the CQ was uploaded after l-g-t-m from
vogelheim@chromium.org
Link to the patchset: https://codereview.chromium.org/2342663004/#ps60001
(title: "updates")

[commit-bot: I haz the power, 2016-09-15 12:55:34]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-15 13:14:39]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2016-09-15 13:15:24]

Description was changed from

==========
Add files missing from gn and fix verify script

R=machenbach@chromium.org
BUG=
==========

to

==========
Add files missing from gn and fix verify script

R=machenbach@chromium.org
BUG=

Committed: https://crrev.com/0e938d4ac0f7d9bbb071cfac5cedcdfef9bbfb14
Cr-Commit-Position: refs/heads/master@{#39447}
==========

[commit-bot: I haz the power, 2016-09-15 13:15:25]

Patchset 4 (id:??) landed as
https://crrev.com/0e938d4ac0f7d9bbb071cfac5cedcdfef9bbfb14
Cr-Commit-Position: refs/heads/master@{#39447}

[Michael Achenbach, 2016-09-19 07:08:18]

lgtm - thanks!