Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2954)

Unified Diff: src/counters.h

Issue 2342643004: [Tracing] Remove unnecessary memory allocation in runtime call stats. (Closed)
Patch Set: rebase Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | src/counters.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/counters.h
diff --git a/src/counters.h b/src/counters.h
index 3049e8673f5e39ea11a6384bd36ebf160b85df46..2b91fc074fbd030ff80aa21f7cb6310156d9b175 100644
--- a/src/counters.h
+++ b/src/counters.h
@@ -791,7 +791,7 @@ class RuntimeCallStats {
void Reset();
V8_NOINLINE void Print(std::ostream& os);
- V8_NOINLINE const char* Dump();
+ V8_NOINLINE std::string Dump();
RuntimeCallStats() {
Reset();
@@ -803,8 +803,6 @@ class RuntimeCallStats {
private:
std::stringstream buffer_;
- std::unique_ptr<char[]> buffer_c_str_;
- size_t len_ = 0;
// Counter to track recursive time events.
RuntimeCallTimer* current_timer_ = NULL;
// Used to track nested tracing scopes.
« no previous file with comments | « no previous file | src/counters.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698