[Tracing] Remove unnecessary memory allocation in runtime call stats.

[Tracing] Remove unnecessary memory allocation in runtime call stats.

Previously we didn't implement TRACE_STR_COPY when we write trace events to
file, which causes us to allocate a growing independent memory chunk for dumped
runtime call stats table. Since we now have a fully functional TRACE_STR_COPY,
this memory allocation can be avoided, this patch removes it.

BUG=v8:5089
Committed: https://crrev.com/e1997bb7d780d12e3a89078e8dd652dcf1d90039
Committed: https://crrev.com/9e640b74b39dc5b0f7fda5e88442826568f2e5a6
Cr-Original-Commit-Position: refs/heads/master@{#39462}
Cr-Commit-Position: refs/heads/master@{#39510}

[lpy, 2016-09-15 21:14:53]

The CQ bit was checked by lpy@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-15 21:15:04]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-15 21:49:23]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-15 21:49:24]

Dry run: This issue passed the CQ dry run.

[lpy, 2016-09-15 21:50:31]

lpy@chromium.org changed reviewers:
+ cbruni@chromium.org, fmeawad@chromium.org

[lpy, 2016-09-15 21:50:32]

PTAL.

[lpy, 2016-09-15 21:56:33]

I can verify this works on Chrome TOT and V8.

[fmeawad, 2016-09-15 22:03:30]

lgtm

[Camillo Bruni, 2016-09-15 23:37:47]

lgtm

[lpy, 2016-09-16 04:10:43]

The CQ bit was checked by lpy@chromium.org

[commit-bot: I haz the power, 2016-09-16 04:10:58]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-16 04:12:55]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-09-16 04:13:24]

Description was changed from

==========
[Tracing] Remove unnecessary memory allocation in runtime call stats.

Previously we didn't implement TRACE_STR_COPY when we write trace events to
file, which causes us to allocate a growing independent memory chunk for dumped
runtime call stats table. Since we now have a fully functional TRACE_STR_COPY,
this memory allocation can be avoided, this patch removes it.

BUG=v8:5089
==========

to

==========
[Tracing] Remove unnecessary memory allocation in runtime call stats.

Previously we didn't implement TRACE_STR_COPY when we write trace events to
file, which causes us to allocate a growing independent memory chunk for dumped
runtime call stats table. Since we now have a fully functional TRACE_STR_COPY,
this memory allocation can be avoided, this patch removes it.

BUG=v8:5089

Committed: https://crrev.com/e1997bb7d780d12e3a89078e8dd652dcf1d90039
Cr-Commit-Position: refs/heads/master@{#39462}
==========

[commit-bot: I haz the power, 2016-09-16 04:13:25]

Patchset 1 (id:??) landed as
https://crrev.com/e1997bb7d780d12e3a89078e8dd652dcf1d90039
Cr-Commit-Position: refs/heads/master@{#39462}

[vogelheim, 2016-09-16 14:20:25]

A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/2349593004/ by vogelheim@chromium.org.

The reason for reverting is: Revert because this breaks V8's roll into Chromium.
ASAN complains about memory accesses in a particular unit test.


Borked roll CL:
https://codereview.chromium.org/2348833002/

Reproduce breakage with:

1, args.gn:
  v8_deprecation_warnings = true
  use_goma = true
  is_asan = true
2, ninja -C out/... content_browsertests
3, out/.../content_browsertests --gtest_filter=V8SamplingProfilerTest.*.

[lpy, 2016-09-16 17:19:17]

Description was changed from

==========
[Tracing] Remove unnecessary memory allocation in runtime call stats.

Previously we didn't implement TRACE_STR_COPY when we write trace events to
file, which causes us to allocate a growing independent memory chunk for dumped
runtime call stats table. Since we now have a fully functional TRACE_STR_COPY,
this memory allocation can be avoided, this patch removes it.

BUG=v8:5089

Committed: https://crrev.com/e1997bb7d780d12e3a89078e8dd652dcf1d90039
Cr-Commit-Position: refs/heads/master@{#39462}
==========

to

==========
[Tracing] Remove unnecessary memory allocation in runtime call stats.

Previously we didn't implement TRACE_STR_COPY when we write trace events to
file, which causes us to allocate a growing independent memory chunk for dumped
runtime call stats table. Since we now have a fully functional TRACE_STR_COPY,
this memory allocation can be avoided, this patch removes it.

BUG=v8:5089

Committed: https://crrev.com/e1997bb7d780d12e3a89078e8dd652dcf1d90039
Cr-Commit-Position: refs/heads/master@{#39462}
==========

[lpy, 2016-09-19 06:39:50]

The CQ bit was checked by lpy@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-19 06:39:54]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[lpy, 2016-09-19 06:42:19]

cbruni@, fmeawad@, I updated the patch a little (changed the Dump to return a
std::string), please take another look.

[commit-bot: I haz the power, 2016-09-19 06:50:04]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-19 06:50:05]

Dry run: Try jobs failed on following builders:
  v8_linux_chromium_gn_rel on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_chromium_gn_rel/bu...)

[lpy, 2016-09-19 06:57:55]

The CQ bit was checked by lpy@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-19 06:58:04]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-19 07:06:36]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-19 07:06:40]

Dry run: Try jobs failed on following builders:
  v8_linux_chromium_gn_rel on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_chromium_gn_rel/bu...)

[Camillo Bruni, 2016-09-19 13:47:48]

lgtm

[lpy, 2016-09-19 17:08:45]

The CQ bit was checked by lpy@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-19 17:08:55]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-19 17:36:23]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-19 17:36:24]

Dry run: This issue passed the CQ dry run.

[lpy, 2016-09-19 18:04:04]

Patchset #2 (id:20001) has been deleted

[lpy, 2016-09-19 18:45:38]

The CQ bit was checked by lpy@chromium.org

[lpy, 2016-09-19 18:45:38]

The patchset sent to the CQ was uploaded after l-g-t-m from
fmeawad@chromium.org, cbruni@chromium.org
Link to the patchset: https://codereview.chromium.org/2342643004/#ps40001
(title: "rebase")

[commit-bot: I haz the power, 2016-09-19 18:45:51]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-19 18:48:03]

Description was changed from

==========
[Tracing] Remove unnecessary memory allocation in runtime call stats.

Previously we didn't implement TRACE_STR_COPY when we write trace events to
file, which causes us to allocate a growing independent memory chunk for dumped
runtime call stats table. Since we now have a fully functional TRACE_STR_COPY,
this memory allocation can be avoided, this patch removes it.

BUG=v8:5089

Committed: https://crrev.com/e1997bb7d780d12e3a89078e8dd652dcf1d90039
Cr-Commit-Position: refs/heads/master@{#39462}
==========

to

==========
[Tracing] Remove unnecessary memory allocation in runtime call stats.

Previously we didn't implement TRACE_STR_COPY when we write trace events to
file, which causes us to allocate a growing independent memory chunk for dumped
runtime call stats table. Since we now have a fully functional TRACE_STR_COPY,
this memory allocation can be avoided, this patch removes it.

BUG=v8:5089

Committed: https://crrev.com/e1997bb7d780d12e3a89078e8dd652dcf1d90039
Cr-Commit-Position: refs/heads/master@{#39462}
==========

[commit-bot: I haz the power, 2016-09-19 18:48:05]

Committed patchset #2 (id:40001)

[commit-bot: I haz the power, 2016-09-19 21:01:37]

Description was changed from

==========
[Tracing] Remove unnecessary memory allocation in runtime call stats.

Previously we didn't implement TRACE_STR_COPY when we write trace events to
file, which causes us to allocate a growing independent memory chunk for dumped
runtime call stats table. Since we now have a fully functional TRACE_STR_COPY,
this memory allocation can be avoided, this patch removes it.

BUG=v8:5089

Committed: https://crrev.com/e1997bb7d780d12e3a89078e8dd652dcf1d90039
Cr-Commit-Position: refs/heads/master@{#39462}
==========

to

==========
[Tracing] Remove unnecessary memory allocation in runtime call stats.

Previously we didn't implement TRACE_STR_COPY when we write trace events to
file, which causes us to allocate a growing independent memory chunk for dumped
runtime call stats table. Since we now have a fully functional TRACE_STR_COPY,
this memory allocation can be avoided, this patch removes it.

BUG=v8:5089

Committed: https://crrev.com/e1997bb7d780d12e3a89078e8dd652dcf1d90039
Committed: https://crrev.com/9e640b74b39dc5b0f7fda5e88442826568f2e5a6
Cr-Original-Commit-Position: refs/heads/master@{#39462}
Cr-Commit-Position: refs/heads/master@{#39510}
==========

[commit-bot: I haz the power, 2016-09-19 21:01:38]

Patchset 2 (id:??) landed as
https://crrev.com/9e640b74b39dc5b0f7fda5e88442826568f2e5a6
Cr-Commit-Position: refs/heads/master@{#39510}