DevTools: Don't refresh CodeMirror if it is hidden

DevTools: Don't refresh CodeMirror if it is hidden
CodeMirror.refresh is expensive, and calling it when CodeMirror is hidden breaks the gutters.

BUG=none

Committed: https://crrev.com/1e5ed305bafdfece6a07cfd342ac08370ad3d28e
Cr-Commit-Position: refs/heads/master@{#418684}

[einbinder, 2016-09-14 18:14:29]

Description was changed from

==========
DevTools: Don't refresh CodeMirror if it is hidden

BUG=none
==========

to

==========
DevTools: Don't refresh CodeMirror if it is hidden
CodeMirror.refresh is expensive, and calling it when CodeMirror is hidden breaks
the gutters.

BUG=none
==========

[einbinder, 2016-09-14 18:17:06]

einbinder@chromium.org changed reviewers:
+ lushnikov@chromium.org

[einbinder, 2016-09-14 18:17:07]

ptal

[lushnikov, 2016-09-14 19:02:35]

lgtm

https://codereview.chromium.org/2342643002/diff/1/third_party/WebKit/Source/d...
File
third_party/WebKit/Source/devtools/front_end/source_frame/SourcesTextEditor.js
(right):

https://codereview.chromium.org/2342643002/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/source_frame/SourcesTextEditor.js:185:
var originalLength = this._gutters.length;
indexOf..

[einbinder, 2016-09-14 19:06:11]

The CQ bit was checked by einbinder@chromium.org

[einbinder, 2016-09-14 19:06:12]

The patchset sent to the CQ was uploaded after l-g-t-m from
lushnikov@chromium.org
Link to the patchset: https://codereview.chromium.org/2342643002/#ps20001
(title: "indexOf")

[commit-bot: I haz the power, 2016-09-14 19:07:02]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-14 21:35:48]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-09-14 21:39:17]

Description was changed from

==========
DevTools: Don't refresh CodeMirror if it is hidden
CodeMirror.refresh is expensive, and calling it when CodeMirror is hidden breaks
the gutters.

BUG=none
==========

to

==========
DevTools: Don't refresh CodeMirror if it is hidden
CodeMirror.refresh is expensive, and calling it when CodeMirror is hidden breaks
the gutters.

BUG=none

Committed: https://crrev.com/1e5ed305bafdfece6a07cfd342ac08370ad3d28e
Cr-Commit-Position: refs/heads/master@{#418684}
==========

[commit-bot: I haz the power, 2016-09-14 21:39:18]

Patchset 2 (id:??) landed as
https://crrev.com/1e5ed305bafdfece6a07cfd342ac08370ad3d28e
Cr-Commit-Position: refs/heads/master@{#418684}

[dgozman, 2016-09-15 01:08:00]

dgozman@chromium.org changed reviewers:
+ dgozman@chromium.org

[dgozman, 2016-09-15 01:08:00]

Should we add a test?