Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2410)

Unified Diff: chrome/browser/resources/offline_pages/offline_internals.js

Issue 2342603004: [Offline pages] Clean up unnecessary DeleteAll calls in offline internals (Closed)
Patch Set: update id in js and remove references to deleted methods Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/resources/offline_pages/offline_internals.js
diff --git a/chrome/browser/resources/offline_pages/offline_internals.js b/chrome/browser/resources/offline_pages/offline_internals.js
index e746c39df7ea0627c570eecdac1a2e474027d62a..46709f50bc2d6707078aaee127c4b122df36606c 100644
--- a/chrome/browser/resources/offline_pages/offline_internals.js
+++ b/chrome/browser/resources/offline_pages/offline_internals.js
@@ -128,14 +128,28 @@ cr.define('offlineInternals', function() {
* Delete all pages in the offline store.
*/
function deleteAllPages() {
- browserProxy_.deleteAllPages().then(pagesDeleted);
+ var checkboxes = document.getElementsByName('stored');
+ var selectedIds = [];
+
+ for (var i = 0; i < checkboxes.length; i++) {
+ selectedIds.push(checkboxes[i].value);
+ }
+
+ browserProxy_.deleteSelectedPages(selectedIds).then(pagesDeleted);
}
/**
* Delete all pending SavePageRequest items in the request queue.
*/
function deleteAllRequests() {
- browserProxy_.deleteAllRequests().then(requestsDeleted);
+ var checkboxes = document.getElementsByName('requests');
+ var selectedIds = [];
+
+ for (var i = 0; i < checkboxes.length; i++) {
+ selectedIds.push(checkboxes[i].value);
+ }
+
+ browserProxy_.deleteSelectedRequests(selectedIds).then(requestsDeleted);
}
/**
@@ -235,8 +249,8 @@ cr.define('offlineInternals', function() {
}
var incognito = loadTimeData.getBoolean('isIncognito');
- $('clear-all').disabled = incognito;
- $('clear-selected').disabled = incognito;
+ $('delete-all-pages').disabled = incognito;
+ $('delete-selected-pages').disabled = incognito;
$('delete-all-requests').disabled = incognito;
$('delete-selected-requests').disabled = incognito;
$('log-model-on').disabled = incognito;
@@ -245,8 +259,8 @@ cr.define('offlineInternals', function() {
$('log-request-off').disabled = incognito;
$('refresh').disabled = incognito;
- $('clear-all').onclick = deleteAllPages;
- $('clear-selected').onclick = deleteSelectedPages;
+ $('delete-all-pages').onclick = deleteAllPages;
+ $('delete-selected-pages').onclick = deleteSelectedPages;
$('delete-all-requests').onclick = deleteAllRequests;
$('delete-selected-requests').onclick = deleteSelectedRequests;
$('refresh').onclick = refreshAll;

Powered by Google App Engine
This is Rietveld 408576698