Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(88)

Issue 2342603003: Don't process more than the queued events during rAF. (Closed)

Created:
4 years, 3 months ago by dtapuska
Modified:
4 years, 3 months ago
Reviewers:
tdresser
CC:
chromium-reviews, mlamouri+watch-content_chromium.org, jam, darin-cc_chromium.org, dtapuska+chromiumwatch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Don't process more than the queued events during rAF. There was potential that a stream events could enter rAF while it was being processed. This was an initial design consideration but after talking with an external partner it appears that probably we should just process what is queued. This gives the benefit that only one type of a given event will be processed during the callback. BUG=625693 Committed: https://crrev.com/ed255334e459137808c04ede96e8a3253ca3dde5 Cr-Commit-Position: refs/heads/master@{#418618}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Fix nit #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -44 lines) Patch
M content/renderer/input/main_thread_event_queue.cc View 1 2 chunks +8 lines, -14 lines 0 comments Download
M content/renderer/input/main_thread_event_queue_unittest.cc View 1 chunk +0 lines, -30 lines 0 comments Download

Messages

Total messages: 16 (10 generated)
dtapuska
4 years, 3 months ago (2016-09-14 14:57:06 UTC) #4
tdresser
LGTM https://codereview.chromium.org/2342603003/diff/1/content/renderer/input/main_thread_event_queue.cc File content/renderer/input/main_thread_event_queue.cc (right): https://codereview.chromium.org/2342603003/diff/1/content/renderer/input/main_thread_event_queue.cc#newcode240 content/renderer/input/main_thread_event_queue.cc:240: in_flight_event_.reset(events_to_process.front().release()); Can we use in_flight_event_ = std::move(events_to_process.front); ?
4 years, 3 months ago (2016-09-14 16:33:26 UTC) #8
dtapuska
https://codereview.chromium.org/2342603003/diff/1/content/renderer/input/main_thread_event_queue.cc File content/renderer/input/main_thread_event_queue.cc (right): https://codereview.chromium.org/2342603003/diff/1/content/renderer/input/main_thread_event_queue.cc#newcode240 content/renderer/input/main_thread_event_queue.cc:240: in_flight_event_.reset(events_to_process.front().release()); On 2016/09/14 16:33:26, tdresser wrote: > Can we ...
4 years, 3 months ago (2016-09-14 17:19:32 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2342603003/20001
4 years, 3 months ago (2016-09-14 17:20:29 UTC) #12
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 3 months ago (2016-09-14 18:34:13 UTC) #14
commit-bot: I haz the power
4 years, 3 months ago (2016-09-14 18:36:32 UTC) #16
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/ed255334e459137808c04ede96e8a3253ca3dde5
Cr-Commit-Position: refs/heads/master@{#418618}

Powered by Google App Engine
This is Rietveld 408576698