Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(375)

Issue 23426002: install-build-deps-android.sh complains about missing ant-1.8 (Closed)

Created:
7 years, 3 months ago by do-not-use
Modified:
7 years, 3 months ago
CC:
chromium-reviews
Visibility:
Public.

Description

install-build-deps-android.sh complains about missing ant-1.8 install-build-deps-android.sh complains about missing ant-1.8 on Ubuntu 13.04. The package is simply called "ant" since Ubuntu 12.04. The script is checking for Ubuntu 12.x but fails to identify 13.x. This patch fixes the script so that "ant" package is installed on Ubuntu >= 12.x, instead of "ant-1.8". Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=220169

Patch Set 1 #

Total comments: 2

Patch Set 2 : Fix nit #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M build/install-build-deps-android.sh View 1 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
do-not-use
7 years, 3 months ago (2013-08-26 10:01:51 UTC) #1
do-not-use
7 years, 3 months ago (2013-08-26 21:00:14 UTC) #2
do-not-use
7 years, 3 months ago (2013-08-28 19:56:23 UTC) #3
Nico
Thanks! https://codereview.chromium.org/23426002/diff/1/build/install-build-deps-android.sh File build/install-build-deps-android.sh (right): https://codereview.chromium.org/23426002/diff/1/build/install-build-deps-android.sh#newcode52 build/install-build-deps-android.sh:52: if [ `/usr/bin/lsb_release -r -s | cut -d"." ...
7 years, 3 months ago (2013-08-28 20:15:41 UTC) #4
do-not-use
https://codereview.chromium.org/23426002/diff/1/build/install-build-deps-android.sh File build/install-build-deps-android.sh (right): https://codereview.chromium.org/23426002/diff/1/build/install-build-deps-android.sh#newcode52 build/install-build-deps-android.sh:52: if [ `/usr/bin/lsb_release -r -s | cut -d"." -f1` ...
7 years, 3 months ago (2013-08-28 20:28:39 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ch.dumez@sisa.samsung.com/23426002/12001
7 years, 3 months ago (2013-08-28 21:02:22 UTC) #6
commit-bot: I haz the power
7 years, 3 months ago (2013-08-29 03:09:46 UTC) #7
Message was sent while issue was closed.
Change committed as 220169

Powered by Google App Engine
This is Rietveld 408576698