Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(334)

Issue 2342593002: [wasm] void is not a valid type for a global. (Closed)

Created:
4 years, 3 months ago by ahaas
Modified:
4 years, 3 months ago
Reviewers:
titzer
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[wasm] void is not a valid type for a global. TEST=unittest WasmModuleVerifyTest.Global_invalid_type2 BUG=chromium:645443 R=titzer@chromium.org Committed: https://crrev.com/05c4afb0ed51d5c50bf69bb99b1e312e4e13c179 Cr-Commit-Position: refs/heads/master@{#39421}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -1 line) Patch
M src/wasm/module-decoder.cc View 1 chunk +3 lines, -0 lines 0 comments Download
M test/unittests/wasm/module-decoder-unittest.cc View 1 chunk +16 lines, -1 line 0 comments Download

Messages

Total messages: 11 (6 generated)
ahaas
4 years, 3 months ago (2016-09-14 13:19:46 UTC) #1
titzer
lgtm Yet another thing that I fixed already in 0xC....
4 years, 3 months ago (2016-09-14 13:34:13 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2342593002/1
4 years, 3 months ago (2016-09-14 14:04:58 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-09-14 15:44:22 UTC) #9
commit-bot: I haz the power
4 years, 3 months ago (2016-09-14 15:45:09 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/05c4afb0ed51d5c50bf69bb99b1e312e4e13c179
Cr-Commit-Position: refs/heads/master@{#39421}

Powered by Google App Engine
This is Rietveld 408576698