Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(139)

Issue 2342553003: Enable CSS hyphens property on stable (Closed)

Created:
4 years, 3 months ago by kojii
Modified:
4 years, 3 months ago
Reviewers:
tkent, eae
CC:
blink-reviews, chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Enable CSS hyphens property on stable This patch enables CSS hyphens property on stable. Following values are valid at this point: Android/Mac: manual | none | auto Other platforms: manual | none BUG=605840 Committed: https://crrev.com/ed7e106e0e48b3afb160a5bdbb37649e307d2b05 Cr-Commit-Position: refs/heads/master@{#419461}

Patch Set 1 #

Patch Set 2 : Rebaseline #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M third_party/WebKit/LayoutTests/virtual/stable/webexposed/css-properties-as-js-properties-expected.txt View 1 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/platform/RuntimeEnabledFeatures.in View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 19 (10 generated)
kojii
PTAL.
4 years, 3 months ago (2016-09-16 09:18:11 UTC) #7
eae
LGTM!
4 years, 3 months ago (2016-09-16 13:18:44 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2342553003/20001
4 years, 3 months ago (2016-09-16 13:19:03 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/261011)
4 years, 3 months ago (2016-09-16 13:26:00 UTC) #12
tkent
lgtm
4 years, 3 months ago (2016-09-19 13:46:52 UTC) #13
kojii
thank you for this late time in Tokyo!
4 years, 3 months ago (2016-09-19 13:47:27 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2342553003/20001
4 years, 3 months ago (2016-09-19 13:47:44 UTC) #16
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 3 months ago (2016-09-19 15:11:24 UTC) #17
commit-bot: I haz the power
4 years, 3 months ago (2016-09-19 15:13:13 UTC) #19
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/ed7e106e0e48b3afb160a5bdbb37649e307d2b05
Cr-Commit-Position: refs/heads/master@{#419461}

Powered by Google App Engine
This is Rietveld 408576698