Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(52)

Issue 2342553002: Measure usage metrics to prepare for adaptive fetching rates in M55 (Closed)

Created:
4 years, 3 months ago by Marc Treib
Modified:
4 years, 3 months ago
Reviewers:
CC:
chromium-reviews
Target Ref:
refs/pending/branch-heads/2840
Project:
chromium
Visibility:
Public.

Description

Measure usage metrics to prepare for adaptive fetching rates in M55 In order to scale to 100% of users in M55, we need adaptive fetching rates for server-side suggestions on the new tab page. This CL implements reporting of usage metrics to UMA. We need to collect these metrics already in M54 so that we have enough data to define default parameters for the adaptive fetching rates in M55. Design doc: https://docs.google.com/a/google.com/document/d/1tDl2Dx_ZPnSyoe7hAe55mT2uTeXDaFVphqsWZEjp3EQ/edit?usp=sharing BUG=644716 Review-Url: https://codereview.chromium.org/2315273002 Cr-Commit-Position: refs/heads/master@{#417336} (cherry picked from commit e13510e5938155d4eb7b8a742919a11aa7f8556c) Committed: https://chromium.googlesource.com/chromium/src/+/fac6b13156a4d9c89778334eb9013354ddef81ec

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+313 lines, -8 lines) Patch
M chrome/browser/android/ntp/ntp_snippets_bridge.cc View 4 chunks +5 lines, -0 lines 0 comments Download
M chrome/browser/ntp_snippets/content_suggestions_service_factory.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/prefs/browser_prefs.cc View 2 chunks +2 lines, -0 lines 0 comments Download
M components/ntp_snippets/BUILD.gn View 1 chunk +2 lines, -0 lines 0 comments Download
M components/ntp_snippets/content_suggestions_service.h View 5 chunks +10 lines, -1 line 0 comments Download
M components/ntp_snippets/content_suggestions_service.cc View 2 chunks +6 lines, -2 lines 0 comments Download
M components/ntp_snippets/content_suggestions_service_unittest.cc View 1 chunk +3 lines, -2 lines 0 comments Download
M components/ntp_snippets/pref_names.h View 1 chunk +18 lines, -0 lines 0 comments Download
M components/ntp_snippets/pref_names.cc View 1 chunk +15 lines, -0 lines 0 comments Download
A components/ntp_snippets/user_classifier.h View 1 chunk +61 lines, -0 lines 0 comments Download
A components/ntp_snippets/user_classifier.cc View 1 chunk +156 lines, -0 lines 0 comments Download
M ios/chrome/browser/ntp_snippets/ios_chrome_content_suggestions_service_factory.cc View 1 chunk +2 lines, -1 line 0 comments Download
M tools/metrics/histograms/histograms.xml View 1 chunk +31 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
Marc Treib
4 years, 3 months ago (2016-09-14 11:12:45 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
fac6b13156a4d9c89778334eb9013354ddef81ec.

Powered by Google App Engine
This is Rietveld 408576698