Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(435)

Unified Diff: src/interpreter/interpreter-assembler.cc

Issue 2342533002: [ignition] inline allocation site creation to call/constructor handlers. (Closed)
Patch Set: Quick fix. Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/code-stubs.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/interpreter/interpreter-assembler.cc
diff --git a/src/interpreter/interpreter-assembler.cc b/src/interpreter/interpreter-assembler.cc
index 2ea7e85acd409946cf43e273c42c93d3b6c01b7e..7d8250944586dab591ab688fbf879607c4658625 100644
--- a/src/interpreter/interpreter-assembler.cc
+++ b/src/interpreter/interpreter-assembler.cc
@@ -646,11 +646,8 @@ Node* InterpreterAssembler::CallJSWithFeedback(Node* function, Node* context,
Bind(&create_allocation_site);
{
- // TODO(mythria): Inline the creation of the allocation site.
- CreateAllocationSiteStub create_stub(isolate());
- CallStub(create_stub.GetCallInterfaceDescriptor(),
- HeapConstant(create_stub.GetCode()), context,
- type_feedback_vector, SmiTag(slot_id));
+ CreateAllocationSiteInFeedbackVector(type_feedback_vector,
+ SmiTag(slot_id));
// Call using CallFunction builtin. CallICs have a PREMONOMORPHIC state.
// They start collecting feedback only when a call is executed the second
@@ -835,14 +832,9 @@ Node* InterpreterAssembler::CallConstruct(Node* constructor, Node* context,
Bind(&create_allocation_site);
{
- // TODO(mythria): Inline the creation of allocation site.
- CreateAllocationSiteStub create_stub(isolate());
- CallStub(create_stub.GetCallInterfaceDescriptor(),
- HeapConstant(create_stub.GetCode()), context,
- type_feedback_vector, SmiTag(slot_id));
- Node* feedback_element =
- LoadFixedArrayElement(type_feedback_vector, slot_id);
- allocation_feedback.Bind(feedback_element);
+ Node* site = CreateAllocationSiteInFeedbackVector(
+ type_feedback_vector, SmiTag(slot_id));
+ allocation_feedback.Bind(site);
Goto(&call_construct_function);
}
« no previous file with comments | « src/code-stubs.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698