Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(417)

Issue 2342533002: [ignition] inline allocation site creation to call/constructor handlers. (Closed)

Created:
4 years, 3 months ago by mvstanton
Modified:
4 years, 3 months ago
CC:
v8-reviews_googlegroups.com, rmcilroy
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[ignition] inline allocation site creation to call/constructor handlers. BUG= Committed: https://crrev.com/0bcef939dc9640b8ace5825592c5dcdbf7a0d3c8 Cr-Commit-Position: refs/heads/master@{#39418}

Patch Set 1 #

Patch Set 2 : Quick fix. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+58 lines, -65 lines) Patch
M src/code-stub-assembler.h View 1 chunk +4 lines, -0 lines 0 comments Download
M src/code-stub-assembler.cc View 1 chunk +46 lines, -0 lines 0 comments Download
M src/code-stubs.cc View 1 chunk +3 lines, -52 lines 0 comments Download
M src/interpreter/interpreter-assembler.cc View 1 2 chunks +5 lines, -13 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
mvstanton
Hi Mythri, Benedikt, Here is a todo from Mythri in the interpreter assembler that I ...
4 years, 3 months ago (2016-09-14 11:36:14 UTC) #2
rmcilroy
Awesome, thanks. LGTM.
4 years, 3 months ago (2016-09-14 12:07:17 UTC) #4
mythria
Thanks for doing this. lgtm.
4 years, 3 months ago (2016-09-14 12:13:47 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2342533002/20001
4 years, 3 months ago (2016-09-14 12:14:49 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 3 months ago (2016-09-14 12:49:41 UTC) #8
commit-bot: I haz the power
4 years, 3 months ago (2016-09-14 12:50:07 UTC) #10
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/0bcef939dc9640b8ace5825592c5dcdbf7a0d3c8
Cr-Commit-Position: refs/heads/master@{#39418}

Powered by Google App Engine
This is Rietveld 408576698