Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(17)

Issue 2342513002: Convert editing/execCommand/queryCommandState-01.html to use w3c test harness (Closed)

Created:
4 years, 3 months ago by yosin_UTC9
Modified:
4 years, 3 months ago
Reviewers:
yoichio, Xiaocheng
CC:
blink-reviews, chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Convert editing/execCommand/queryCommandState-01.html to use w3c test harness This patch converts "editing/execCommand/queryCommandState-01.html" to use w3c test harness to simplify test script for improving code health. BUG=n/a TEST=n/a; no behavior changes Committed: https://crrev.com/f55e7507eb4104a839a39fd4f8cd5f1a90a9dc6f Cr-Commit-Position: refs/heads/master@{#418498}

Patch Set 1 : 2016-09-14T13:15:40 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -58 lines) Patch
M third_party/WebKit/LayoutTests/editing/execCommand/queryCommandState-01.html View 1 chunk +19 lines, -42 lines 0 comments Download
D third_party/WebKit/LayoutTests/editing/execCommand/queryCommandState-01-expected.txt View 1 chunk +0 lines, -16 lines 0 comments Download

Messages

Total messages: 15 (10 generated)
yosin_UTC9
PTAL
4 years, 3 months ago (2016-09-14 05:16:28 UTC) #7
yoichio
lgtm
4 years, 3 months ago (2016-09-14 05:49:45 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2342513002/1
4 years, 3 months ago (2016-09-14 05:51:35 UTC) #12
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-09-14 05:56:45 UTC) #13
commit-bot: I haz the power
4 years, 3 months ago (2016-09-14 05:59:35 UTC) #15
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/f55e7507eb4104a839a39fd4f8cd5f1a90a9dc6f
Cr-Commit-Position: refs/heads/master@{#418498}

Powered by Google App Engine
This is Rietveld 408576698