Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(149)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2342503002: Revert of Revert "[telemetry] Wire TsProxy through telemetry's network stack." (Closed)

Created:
4 years, 3 months ago by nednguyen
Modified:
4 years, 3 months ago
CC:
catapult-reviews_chromium.org, telemetry-reviews_chromium.org, kouhei (in TOK)
Base URL:
https://github.com/catapult-project/catapult.git@master
Target Ref:
refs/heads/master
Project:
catapult
Visibility:
Public.

Description

Revert of Revert "[telemetry] Wire TsProxy through telemetry's network stack." (patchset #1 id:1 of https://codereview.chromium.org/2267613002/ ) Reason for revert: Webview now support --proxy-server flag (see attached bug) Original issue's description: > Revert "[telemetry] Wire TsProxy through telemetry's network stack." > > This reverts commit 9fcccf0b65703994c9541273f00a993806a95356. > > Revert "[Telemetry] Explictly initialize & clean up network_controller" > > This reverts commit 30ce231266c6fb6147bb6df7c56a7eb75c23fccf. > > Seems like webview currently does not support proxy server? > (See attached chromium bug) > > BUG=chromium:639632 > BUG=catapult:#2584 > > TBR=pmeenan@chromium.org > > Committed: https://chromium.googlesource.com/external/github.com/catapult-project/catapult/+/947506bacfb5047857a52033256635faebf38af2 TBR=nednguyen@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=chromium:639632 Committed: https://chromium.googlesource.com/external/github.com/catapult-project/catapult/+/b86cfef4b9da4749ff51e0fc4432869f8209dc42

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+220 lines, -635 lines) Patch
M telemetry/telemetry/core/local_server.py View 2 chunks +10 lines, -8 lines 0 comments Download
M telemetry/telemetry/core/network_controller.py View 1 chunk +3 lines, -0 lines 0 comments Download
M telemetry/telemetry/internal/backends/chrome/chrome_browser_backend.py View 1 chunk +3 lines, -11 lines 0 comments Download
M telemetry/telemetry/internal/backends/chrome/chrome_browser_backend_unittest.py View 3 chunks +10 lines, -11 lines 0 comments Download
M telemetry/telemetry/internal/backends/chrome/cros_browser_backend.py View 1 chunk +2 lines, -4 lines 0 comments Download
M telemetry/telemetry/internal/browser/browser_unittest.py View 4 chunks +28 lines, -18 lines 0 comments Download
M telemetry/telemetry/internal/browser/extension_unittest.py View 6 chunks +26 lines, -9 lines 0 comments Download
M telemetry/telemetry/internal/forwarders/__init__.py View 3 chunks +9 lines, -30 lines 0 comments Download
M telemetry/telemetry/internal/forwarders/android_forwarder.py View 2 chunks +12 lines, -15 lines 0 comments Download
M telemetry/telemetry/internal/forwarders/cros_forwarder.py View 2 chunks +13 lines, -11 lines 0 comments Download
M telemetry/telemetry/internal/forwarders/cros_forwarder_unittest.py View 1 chunk +5 lines, -12 lines 0 comments Download
M telemetry/telemetry/internal/forwarders/do_nothing_forwarder.py View 2 chunks +18 lines, -32 lines 0 comments Download
M telemetry/telemetry/internal/forwarders/do_nothing_forwarder_unittest.py View 1 chunk +7 lines, -30 lines 0 comments Download
M telemetry/telemetry/internal/platform/android_platform_backend.py View 2 chunks +4 lines, -0 lines 0 comments Download
M telemetry/telemetry/internal/platform/cros_platform_backend.py View 2 chunks +0 lines, -12 lines 0 comments Download
M telemetry/telemetry/internal/platform/network_controller_backend.py View 7 chunks +49 lines, -28 lines 0 comments Download
D telemetry/telemetry/internal/platform/network_controller_backend_unittest.py View 1 chunk +0 lines, -390 lines 0 comments Download
M telemetry/telemetry/internal/platform/platform_backend.py View 2 chunks +3 lines, -7 lines 0 comments Download
M telemetry/telemetry/internal/util/ts_proxy_server.py View 3 chunks +7 lines, -4 lines 0 comments Download
M telemetry/telemetry/internal/util/ts_proxy_server_unittest.py View 1 chunk +1 line, -1 line 0 comments Download
M telemetry/telemetry/internal/util/wpr_server.py View 1 chunk +1 line, -1 line 0 comments Download
M telemetry/telemetry/page/shared_page_state.py View 1 chunk +1 line, -0 lines 0 comments Download
M telemetry/telemetry/testing/browser_test_case.py View 2 chunks +3 lines, -1 line 0 comments Download
M telemetry/telemetry/testing/fakes/__init__.py View 1 chunk +3 lines, -0 lines 0 comments Download
M telemetry/telemetry/testing/serially_executed_browser_test_case.py View 2 chunks +2 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
nednguyen
Created Revert of Revert "[telemetry] Wire TsProxy through telemetry's network stack."
4 years, 3 months ago (2016-09-14 00:26:35 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2342503002/1
4 years, 3 months ago (2016-09-14 00:26:39 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/external/github.com/catapult-project/catapult/+/b86cfef4b9da4749ff51e0fc4432869f8209dc42
4 years, 3 months ago (2016-09-14 00:48:54 UTC) #5
perezju
4 years, 3 months ago (2016-09-14 15:25:29 UTC) #6
Message was sent while issue was closed. 
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/2335403003/ by perezju@chromium.org.

The reason for reverting is: Broke WPR replay on WebView bots.

Powered by Google App Engine
This is Rietveld 408576698