Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2953)

Unified Diff: chrome/browser/resources/settings/site_settings/site_details.js

Issue 2342473003: [MD settings] site details url below Site details subpage title (Closed)
Patch Set: merge with master Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/resources/settings/site_settings/site_details.js
diff --git a/chrome/browser/resources/settings/site_settings/site_details.js b/chrome/browser/resources/settings/site_settings/site_details.js
index e5a36d9c90c0591fd5c13176ae51c0b49d8ac8df..23a96b74c3a57b31981c2aa90e1d53f5c7943b1b 100644
--- a/chrome/browser/resources/settings/site_settings/site_details.js
+++ b/chrome/browser/resources/settings/site_settings/site_details.js
@@ -45,6 +45,15 @@ Polymer({
},
/**
+ * @param {string} url Location of an image to get a set of icons for.
+ * @return {string} A set of icon URLs.
+ * @private
+ */
+ getIconSet_: function(url) {
+ return cr.icon.getFavicon(this.ensureUrlHasScheme(url));
+ },
Finnur 2016/09/14 11:00:21 The behavior already has a computeSiteIcon functio
dschuyler 2016/09/14 19:11:33 Done.
+
+ /**
* Handler for when the origin changes.
*/
onSiteChanged_: function() {

Powered by Google App Engine
This is Rietveld 408576698