[MD settings] site details url below Site details subpage title

[MD settings] site details url below Site details subpage title

This CL moves the site URL out of the subpage title and into the body of
the subpage. The new title is Site settings. In the new position, the
url has its favicon. This is similar to a previous revision done by
Finnur@.

BUG=646616
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Committed: https://crrev.com/2d6dbcaaff9ae4a9173ec1a5405f62b9ffe6365c
Cr-Commit-Position: refs/heads/master@{#419051}

[dschuyler, 2016-09-13 23:06:48]

Description was changed from

==========
[MD settings] site details url below Site details subpage title

This CL moves the site URL out of the subpage title and into the body of
the subpage. The new title is Site settings. In the new position, the
url has its favicon. This is similar to a previous revision done by
Finnur@.

BUG=646616
==========

to

==========
[MD settings] site details url below Site details subpage title

This CL moves the site URL out of the subpage title and into the body of
the subpage. The new title is Site settings. In the new position, the
url has its favicon. This is similar to a previous revision done by
Finnur@.

BUG=646616
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[dschuyler, 2016-09-13 23:06:51]

The CQ bit was checked by dschuyler@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-13 23:07:23]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[dschuyler, 2016-09-13 23:09:35]

dschuyler@chromium.org changed reviewers:
+ finnur@chromium.org

[dschuyler, 2016-09-13 23:09:35]

i.e. changing it back to the way you had it previously.

[commit-bot: I haz the power, 2016-09-13 23:10:48]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-13 23:10:49]

Dry run: Try jobs failed on following builders:
  android_compile_dbg on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_comp...)
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)
  mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[dschuyler, 2016-09-14 00:40:12]

The CQ bit was checked by dschuyler@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-14 00:40:42]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-14 01:00:28]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-14 01:00:29]

Dry run: Try jobs failed on following builders:
  android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_...)

[Finnur, 2016-09-14 11:00:21]

The Android code... is that accidental inclusion in the CL? I don't see how it
is related.

https://codereview.chromium.org/2342473003/diff/20001/chrome/browser/resource...
File chrome/browser/resources/settings/site_settings/site_details.js (right):

https://codereview.chromium.org/2342473003/diff/20001/chrome/browser/resource...
chrome/browser/resources/settings/site_settings/site_details.js:54: },
The behavior already has a computeSiteIcon function, which does essentially the
same.

[dschuyler, 2016-09-14 18:21:55]

The CQ bit was checked by dschuyler@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-14 18:22:27]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[dschuyler, 2016-09-14 18:24:40]

On 2016/09/14 11:00:21, Finnur wrote:
> The Android code... is that accidental inclusion in the CL? I don't see how it
> is related.

For some reason those didn't show up in my local diff/changes(!). They still
don't
show as changes. After pulling down another new master copy, it seems to have 
cleared up. Thanks for pointing it out.

[commit-bot: I haz the power, 2016-09-14 18:33:23]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-14 18:33:25]

Dry run: Try jobs failed on following builders:
  closure_compilation on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/closure_compila...)

[dschuyler, 2016-09-14 19:10:37]

The CQ bit was checked by dschuyler@chromium.org to run a CQ dry run

[dschuyler, 2016-09-14 19:10:50]

Patchset #3 (id:40001) has been deleted

[dschuyler, 2016-09-14 19:11:33]

https://codereview.chromium.org/2342473003/diff/20001/chrome/browser/resource...
File chrome/browser/resources/settings/site_settings/site_details.js (right):

https://codereview.chromium.org/2342473003/diff/20001/chrome/browser/resource...
chrome/browser/resources/settings/site_settings/site_details.js:54: },
On 2016/09/14 11:00:21, Finnur wrote:
> The behavior already has a computeSiteIcon function, which does essentially
the
> same.

Done.

[commit-bot: I haz the power, 2016-09-14 19:11:57]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-14 20:19:49]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-14 20:19:52]

Dry run: Try jobs failed on following builders:
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Finnur, 2016-09-15 12:37:25]

LGTM

[dschuyler, 2016-09-15 23:17:56]

The CQ bit was checked by dschuyler@chromium.org

[commit-bot: I haz the power, 2016-09-15 23:18:37]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-16 00:25:22]

Committed patchset #3 (id:60001)

[commit-bot: I haz the power, 2016-09-16 00:28:20]

Description was changed from

==========
[MD settings] site details url below Site details subpage title

This CL moves the site URL out of the subpage title and into the body of
the subpage. The new title is Site settings. In the new position, the
url has its favicon. This is similar to a previous revision done by
Finnur@.

BUG=646616
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
[MD settings] site details url below Site details subpage title

This CL moves the site URL out of the subpage title and into the body of
the subpage. The new title is Site settings. In the new position, the
url has its favicon. This is similar to a previous revision done by
Finnur@.

BUG=646616
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Committed: https://crrev.com/2d6dbcaaff9ae4a9173ec1a5405f62b9ffe6365c
Cr-Commit-Position: refs/heads/master@{#419051}
==========

[commit-bot: I haz the power, 2016-09-16 00:28:21]

Patchset 3 (id:??) landed as
https://crrev.com/2d6dbcaaff9ae4a9173ec1a5405f62b9ffe6365c
Cr-Commit-Position: refs/heads/master@{#419051}