Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3)

Issue 2342473002: improve import URI completions at EOF (Closed)

Created:
4 years, 3 months ago by danrubel
Modified:
4 years, 3 months ago
Reviewers:
scheglov
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : if to else if #

Patch Set 3 : merge #

Patch Set 4 : update tests #

Unified diffs Side-by-side diffs Delta from patch set Stats (+96 lines, -9 lines) Patch
M pkg/analysis_server/lib/src/services/completion/dart/uri_contributor.dart View 1 1 chunk +33 lines, -5 lines 0 comments Download
M pkg/analysis_server/test/completion_test.dart View 1 2 3 2 chunks +2 lines, -4 lines 0 comments Download
M pkg/analysis_server/test/services/completion/dart/uri_contributor_test.dart View 2 chunks +61 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
danrubel
4 years, 3 months ago (2016-09-13 22:35:19 UTC) #2
scheglov
LGTM
4 years, 3 months ago (2016-09-14 00:03:02 UTC) #3
danrubel
4 years, 3 months ago (2016-09-14 15:22:32 UTC) #5
Message was sent while issue was closed.
Committed patchset #4 (id:60001) manually as
023295912ae3e6617a604e788d46581c0349307e (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698