[NTP] Fix article suggestion clicks contributing to Most Visited tiles

components/history/core/browser/history_backend.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "components/history/core/browser/history_backend.h"
 
 #include <algorithm>
 #include <functional>
 #include <list>
 #include <map>
@@ skipping 475 matching lines @@
 
   // If the user is adding older history, we need to make sure our times
   // are correct.
   if (request.time < first_recorded_time_)
     first_recorded_time_ = request.time;
 
   ui::PageTransition request_transition = request.transition;
   bool is_keyword_generated = ui::PageTransitionCoreTypeIs(
       request_transition, ui::PAGE_TRANSITION_KEYWORD_GENERATED);
 
+  bool has_redirects = request.redirects.size() > 1;
+
+  // data: scheme is sometimes used in combination with AUTO_BOOKMARK to fake a
+  // redirect as way to make sure it doesn't show up in most visited. Such
+  // entries should be ignored for the purpose of history (including omnibox
+  // autocomplete and most visited).
+  if (!has_redirects &&

[sky, 2016/09/14 18:01:51]

Wouldn't this mean the page won't show up in history at all?

[mastiz, 2016/09/14 18:10:18]

The article itself (redirectee) gets listed in history, but not the dummy
'data:' redirect, according to my testing on Android. I don't however fully
understand why this case doesn't get reported as a single navigation chain (i.e.
single call to AddPage()).

[sky, 2016/09/14 18:17:49]

I believe this change would make it so data urls are never added though, right?
That isn't the case today, which would mean for users that have data urls in top
sites they would no longer end up getting them (they would slowly expire).

[mastiz, 2016/09/14 18:22:02]

More specifically, data URLs with AUTO_BOOKMARK (note for example that clicks on
actual bookmarks are marked with LINK). Your point is still valid, but it should
be rare, and the server-side implementation of Chrome Suggestions discards such
scheme. WDYT?

[mastiz, 2016/09/14 18:40:47]

Also, would it be any better if we left FROM_ADDRESS_BAR cases unaffected?

+      ui::PageTransitionCoreTypeIs(request_transition,
+                                   ui::PAGE_TRANSITION_AUTO_BOOKMARK) &&
+      request.url.SchemeIs(url::kDataScheme)) {
+    return;
+  }
+
   // If the user is navigating to a not-previously-typed intranet hostname,
   // change the transition to TYPED so that the omnibox will learn that this is
   // a known host.
-  bool has_redirects = request.redirects.size() > 1;
   if (ui::PageTransitionIsMainFrame(request_transition) &&
       !ui::PageTransitionCoreTypeIs(request_transition,
                                     ui::PAGE_TRANSITION_TYPED) &&
       !is_keyword_generated) {
     const GURL& origin_url(has_redirects ? request.redirects[0] : request.url);
     if (origin_url.SchemeIs(url::kHttpScheme) ||
         origin_url.SchemeIs(url::kHttpsScheme) ||
         origin_url.SchemeIs(url::kFtpScheme)) {
       std::string host(origin_url.host());
       size_t registry_length =
@@ skipping 2158 matching lines @@
   // transaction is currently open.
   db_->CommitTransaction();
   db_->Vacuum();
   db_->BeginTransaction();
   db_->GetStartDate(&first_recorded_time_);
 
   return true;
 }
 
 }  // namespace history