Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(110)

Side by Side Diff: chrome/android/java/src/org/chromium/chrome/browser/ntp/NewTabPage.java

Issue 2342453003: [NTP] Fix article suggestion clicks contributing to Most Visited tiles (Closed)
Patch Set: Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2015 The Chromium Authors. All rights reserved. 1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 package org.chromium.chrome.browser.ntp; 5 package org.chromium.chrome.browser.ntp;
6 6
7 import android.annotation.TargetApi; 7 import android.annotation.TargetApi;
8 import android.content.Context; 8 import android.content.Context;
9 import android.graphics.Canvas; 9 import android.graphics.Canvas;
10 import android.graphics.Point; 10 import android.graphics.Point;
(...skipping 294 matching lines...) Expand 10 before | Expand all | Expand 10 after
305 public void trackSnippetCategoryActionClick(int category, int position) { 305 public void trackSnippetCategoryActionClick(int category, int position) {
306 mSnippetsBridge.onMoreButtonClicked(category, position); 306 mSnippetsBridge.onMoreButtonClicked(category, position);
307 } 307 }
308 308
309 @Override 309 @Override
310 public void openSnippet(int windowOpenDisposition, SnippetArticle articl e) { 310 public void openSnippet(int windowOpenDisposition, SnippetArticle articl e) {
311 mSnippetsBridge.onSuggestionOpened(article.mGlobalPosition, article. mCategory, 311 mSnippetsBridge.onSuggestionOpened(article.mGlobalPosition, article. mCategory,
312 article.mPosition, article.mPublishTimestampMilliseconds, ar ticle.mScore, 312 article.mPosition, article.mPublishTimestampMilliseconds, ar ticle.mScore,
313 windowOpenDisposition); 313 windowOpenDisposition);
314 NewTabPageUma.monitorContentSuggestionVisit(mTab, article.mCategory) ; 314 NewTabPageUma.monitorContentSuggestionVisit(mTab, article.mCategory) ;
315 openUrl(windowOpenDisposition, article.mUrl); 315 openUrl(windowOpenDisposition, article.getPossiblyWrappedUrl());
316 } 316 }
317 317
318 private void openUrl(int windowOpenDisposition, String url) { 318 private void openUrl(int windowOpenDisposition, String url) {
319 assert !mIsDestroyed; 319 assert !mIsDestroyed;
320 switch (windowOpenDisposition) { 320 switch (windowOpenDisposition) {
321 case WindowOpenDisposition.CURRENT_TAB: 321 case WindowOpenDisposition.CURRENT_TAB:
322 mTab.loadUrl(new LoadUrlParams(url, PageTransition.AUTO_BOOK MARK)); 322 mTab.loadUrl(new LoadUrlParams(url, PageTransition.AUTO_BOOK MARK));
323 break; 323 break;
324 case WindowOpenDisposition.NEW_FOREGROUND_TAB: 324 case WindowOpenDisposition.NEW_FOREGROUND_TAB:
325 openUrlInNewTab(url, false); 325 openUrlInNewTab(url, false);
(...skipping 588 matching lines...) Expand 10 before | Expand all | Expand 10 after
914 @Override 914 @Override
915 public boolean shouldCaptureThumbnail() { 915 public boolean shouldCaptureThumbnail() {
916 return mNewTabPageView.shouldCaptureThumbnail(); 916 return mNewTabPageView.shouldCaptureThumbnail();
917 } 917 }
918 918
919 @Override 919 @Override
920 public void captureThumbnail(Canvas canvas) { 920 public void captureThumbnail(Canvas canvas) {
921 mNewTabPageView.captureThumbnail(canvas); 921 mNewTabPageView.captureThumbnail(canvas);
922 } 922 }
923 } 923 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698