Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7)

Unified Diff: chrome/browser/android/offline_pages/downloads/offline_page_download_bridge.cc

Issue 2342443006: [Offline pages] Use the new policy bits (Closed)
Patch Set: i think i got it! Made sure it compiles Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | components/offline_pages/background/request_coordinator.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/android/offline_pages/downloads/offline_page_download_bridge.cc
diff --git a/chrome/browser/android/offline_pages/downloads/offline_page_download_bridge.cc b/chrome/browser/android/offline_pages/downloads/offline_page_download_bridge.cc
index 5b6e72285c1ee2601397e78052b82b452b078dc8..20a1aa1f085bb0549ee6cc4d6b79abf5bfdd1bc7 100644
--- a/chrome/browser/android/offline_pages/downloads/offline_page_download_bridge.cc
+++ b/chrome/browser/android/offline_pages/downloads/offline_page_download_bridge.cc
@@ -21,6 +21,7 @@
#include "chrome/browser/profiles/profile_android.h"
#include "components/offline_pages/background/request_coordinator.h"
#include "components/offline_pages/client_namespace_constants.h"
+#include "components/offline_pages/client_policy_controller.h"
#include "components/offline_pages/downloads/download_ui_item.h"
#include "components/offline_pages/offline_page_feature.h"
#include "components/offline_pages/offline_page_model.h"
@@ -70,12 +71,13 @@ ScopedJavaLocalRef<jobject> ToJavaOfflinePageDownloadItem(
std::vector<int64_t> FilterRequestsByGuid(
std::vector<std::unique_ptr<SavePageRequest>> requests,
- const std::string& guid) {
+ const std::string& guid,
+ ClientPolicyController* policy_controller) {
std::vector<int64_t> request_ids;
for (const auto& request : requests) {
if (request->client_id().id == guid &&
- (request->client_id().name_space == kDownloadNamespace ||
- request->client_id().name_space == kAsyncNamespace)) {
+ policy_controller->IsSupportedByDownload(
+ request->client_id().name_space)) {
request_ids.push_back(request->request_id());
}
}
@@ -93,8 +95,8 @@ void CancelRequestsContinuation(
RequestCoordinator* coordinator =
RequestCoordinatorFactory::GetForBrowserContext(browser_context);
if (coordinator) {
- std::vector<int64_t> request_ids =
- FilterRequestsByGuid(std::move(requests), guid);
+ std::vector<int64_t> request_ids = FilterRequestsByGuid(
+ std::move(requests), guid, coordinator->GetPolicyController());
coordinator->RemoveRequests(request_ids,
base::Bind(&CancelRequestCallback));
} else {
@@ -109,7 +111,8 @@ void PauseRequestsContinuation(
RequestCoordinator* coordinator =
RequestCoordinatorFactory::GetForBrowserContext(browser_context);
if (coordinator)
- coordinator->PauseRequests(FilterRequestsByGuid(std::move(requests), guid));
+ coordinator->PauseRequests(FilterRequestsByGuid(
+ std::move(requests), guid, coordinator->GetPolicyController()));
else
LOG(WARNING) << "PauseRequestsContinuation has no valid coordinator.";
}
@@ -121,8 +124,8 @@ void ResumeRequestsContinuation(
RequestCoordinator* coordinator =
RequestCoordinatorFactory::GetForBrowserContext(browser_context);
if (coordinator)
- coordinator->ResumeRequests(
- FilterRequestsByGuid(std::move(requests), guid));
+ coordinator->ResumeRequests(FilterRequestsByGuid(
+ std::move(requests), guid, coordinator->GetPolicyController()));
else
LOG(WARNING) << "ResumeRequestsContinuation has no valid coordinator.";
}
« no previous file with comments | « no previous file | components/offline_pages/background/request_coordinator.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698