[Offline pages] Use the new policy bits

components/ntp_snippets/offline_pages/offline_page_suggestions_provider.cc

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "components/ntp_snippets/offline_pages/offline_page_suggestions_provider.h"
 
 #include <algorithm>
 
 #include "base/bind.h"
 #include "base/guid.h"
 #include "base/location.h"
 #include "base/strings/string_number_conversions.h"
 #include "base/strings/utf_string_conversions.h"
 #include "base/threading/thread_task_runner_handle.h"
 #include "base/values.h"
 #include "components/ntp_snippets/pref_names.h"
 #include "components/offline_pages/client_namespace_constants.h"
+#include "components/offline_pages/client_policy_controller.h"
 #include "components/prefs/pref_registry_simple.h"
 #include "components/prefs/pref_service.h"
 #include "grit/components_strings.h"
 #include "ui/base/l10n/l10n_util.h"
 #include "ui/gfx/image/image.h"
 
 using offline_pages::MultipleOfflinePageItemResult;
 using offline_pages::OfflinePageModel;
 using offline_pages::OfflinePageItem;
 
 namespace ntp_snippets {
 
 namespace {
 
 const int kMaxSuggestionsCount = 5;
 
 struct OrderByMostRecentlyVisited {
   bool operator()(const OfflinePageItem* left,
                   const OfflinePageItem* right) const {
     return left->last_access_time > right->last_access_time;
   }
 };
 
 bool IsRecentTab(const offline_pages::ClientId& client_id) {
   return client_id.name_space == offline_pages::kLastNNamespace;
 }
 
 bool IsDownload(const offline_pages::ClientId& client_id) {
-  // TODO(pke): Use kDownloadNamespace once the OfflinePageModel uses that.
-  // The current logic is taken from DownloadUIAdapter::IsVisibleInUI.
-  return client_id.name_space == offline_pages::kAsyncNamespace &&
+  return offline_pages::ClientPolicyController().IsSupportedByDownload(

[Dmitry Titov, 2016/09/20 18:51:55]

This is unorthodox way to use a constructor. A better way would be if either
those methods were static, so you would do CPC::IsFoo(..), or use the existing
OfflinePageModel::getPolicyController(). 
I think calling a ctor w/o 'new' is a dangerous thing...  

+             client_id.name_space) &&
          base::IsValidGUID(client_id.id);
 }
 
 }  // namespace
 
 OfflinePageSuggestionsProvider::OfflinePageSuggestionsProvider(
     bool recent_tabs_enabled,
     bool downloads_enabled,
     bool download_manager_ui_enabled,
     ContentSuggestionsProvider::Observer* observer,
@@ skipping 326 matching lines @@
 void OfflinePageSuggestionsProvider::StoreDismissedIDsToPrefs(
     Category category,
     const std::set<std::string>& dismissed_ids) {
   base::ListValue list;
   for (const std::string& dismissed_id : dismissed_ids)
     list.AppendString(dismissed_id);
   pref_service_->Set(GetDismissedPref(category), list);
 }
 
 }  // namespace ntp_snippets